Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add feature flag for skipping forecasting #26717

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

zlwaterfield
Copy link
Contributor

Changes

Following up on #26714 and add a feature flag to enable the include_forecasting=false

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

It doesn't have an impact.

How did you test this code?

Manually

@zlwaterfield zlwaterfield self-assigned this Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Size Change: +52 B (0%)

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.11 MB +52 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@patricio-posthog patricio-posthog merged commit 83257b4 into master Dec 6, 2024
96 checks passed
@patricio-posthog patricio-posthog deleted the zach/billing-forecasting-ff branch December 6, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants