Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating logic to show the view recording button in the feature flag page #26451

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: updating logic to show the view recording button in the feature flag page #26451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/scenes/feature-flags/FeatureFlag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ export function FeatureFlag({ id }: { id?: string } = {}): JSX.Element {
</div>
</div>
<LemonDivider />
<FeatureFlagRollout id={id} />
<FeatureFlagRollout />
<LemonDivider />
<FeatureFlagReleaseConditions
id={`${featureFlag.id}`}
Expand Down Expand Up @@ -724,7 +724,7 @@ function variantConcatWithPunctuation(phrases: string[]): string {
return `${phrases[0]} and ${phrases.length - 1} more sets`
}

function FeatureFlagRollout({ readOnly, id }: { readOnly?: boolean; id?: string }): JSX.Element {
function FeatureFlagRollout({ readOnly }: { readOnly?: boolean }): JSX.Element {
const {
multivariateEnabled,
variants,
Expand Down Expand Up @@ -989,7 +989,7 @@ function FeatureFlagRollout({ readOnly, id }: { readOnly?: boolean; id?: string
</div>
)}
</div>
{id !== 'new' && (
{readOnly && (
<div>
<h3 className="l3">Recordings</h3>
<p>Watch recordings of people who have been exposed to the feature flag.</p>
Expand Down
Loading