Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating logic to show the view recording button in the feature flag page #26451

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

surbhi-posthog
Copy link
Contributor

Problem

We only want to show the view recording button for the readOnly state of the page so I'm updating the logic to show the button.

This was the original PR that shows the button in the edit page as well: #26407

Changes

Before After
Edit Page Updated Page

Does this work well for both Cloud and self-hosted?

Cloud: Yes
Self-hosted: TBD

How did you test this code?

Locally: http://localhost:8000/project/2/feature_flags/12

@surbhi-posthog surbhi-posthog marked this pull request as ready for review November 27, 2024 00:55
Copy link
Contributor

@zlwaterfield zlwaterfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

@surbhi-posthog surbhi-posthog merged commit 3305554 into master Nov 27, 2024
99 checks passed
@surbhi-posthog surbhi-posthog deleted the recording_button branch November 27, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants