chore(flags): cleaning up some flags stuff #26444
Merged
+545
−699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarticus
commented
Nov 26, 2024
| @@ -96,4 +96,4 @@ ahash = "0.8.11" | |||
| aws-config = { version = "1.1.7", features = ["behavior-version-latest"] } | |||
| aws-sdk-s3 = "1.58.0" | |||
| mockall = "0.13.0" | |||
| moka = { version = "0.12.8", features = ["sync"] } | |||
| moka = { version = "0.12.8", features = ["sync", "future"] } | |||
There was a problem hiding this comment.
added this feature to the workspace version of moka because I need it for flags
| @@ -40,7 +40,7 @@ common-metrics = { path = "../common/metrics" } | |||
| tower = { workspace = true } | |||
| derive_builder = "0.20.1" | |||
| petgraph = "0.6.5" | |||
| moka = { version = "0.12.8", features = ["future"] } | |||
| moka = { workspace = true } | |||
There was a problem hiding this comment.
use the workspace version
havenbarnes
reviewed
Nov 27, 2024
rust/feature-flags/src/config.rs
Outdated
| @@ -98,6 +98,12 @@ pub struct Config { | |||
|
|
|||
| #[envconfig(from = "TEAM_IDS_TO_TRACK", default = "all")] | |||
| pub team_ids_to_track: TeamIdsToTrack, | |||
|
|
|||
| #[envconfig(from = "CACHE_MAX_CAPACITY", default = "100000")] | |||
| pub cache_max_capacity: u64, | |||
There was a problem hiding this comment.
nit: adding a unit to the name like cache_ttl_seconds has would be better? e.g. cache_max_bytes_capacity / cache_max_teams_capacity
There was a problem hiding this comment.
v good point, will do that.
…/posthog into chore/optimize-new-flags-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Olly left a bunch of comments on my cohorts PRs, so I implemented them here as to not clutter other PRs too much.
Here's the list of comments I addressed:
This shouldn't have any functional changes, and all the existing tests passed.