Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flags): add more metrics for new flags service #26447

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

dmarticus
Copy link
Contributor

Flags service is almost ready to hit with real traffic but I want to see how the metrics are looking, so I'm adding in some metrics around common access paths, including:

  • pulling the team information from redis
  • pulling flags information from redis
  • pulling cohort information from application-persisted in-memory cache vs postgres
  • pulling property information request-persisted in-memory cache vs postgres
  • failures to update redis
  • failures to evaluate flags

Copy link
Contributor

@havenbarnes havenbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to have some same diffs as #26444? Mostly focused on the metrics you added, they look great!

@dmarticus
Copy link
Contributor Author

this seems to have some same diffs as #26444? Mostly focused on the metrics you added, they look great!

yeah my b, forgot to change the branch origination. Just updated.

@dmarticus dmarticus changed the base branch from master to chore/optimize-new-flags-service November 27, 2024 19:12
Base automatically changed from chore/optimize-new-flags-service to master November 27, 2024 20:59
@dmarticus dmarticus enabled auto-merge (squash) November 27, 2024 21:04
@dmarticus dmarticus merged commit 5da2d74 into master Nov 27, 2024
80 checks passed
@dmarticus dmarticus deleted the feat/metrics-for-common-flag-paths branch November 27, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants