Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start of clickhouse server version bump to 24.8 #25189

Merged
merged 111 commits into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
a447bd7
feat: start of clickhouse server version bump to 24.3
fuziontech Sep 24, 2024
8f04253
try this
fuziontech Sep 25, 2024
e24b318
this seems to work (not null)
fuziontech Sep 25, 2024
50b30a8
back to nullable
fuziontech Sep 25, 2024
bf887fc
Merge branch 'master' into ch-24.3
fuziontech Sep 25, 2024
27db79b
Add casts to sessions v2 to fix nullable issue
robbie-c Sep 26, 2024
fba852d
Update query snapshots
github-actions[bot] Sep 26, 2024
ab8450e
24.3 -> 24.4 and ch
fuziontech Oct 1, 2024
f3f9e38
Update query snapshots
github-actions[bot] Oct 1, 2024
f51ecb7
back to nullable
fuziontech Oct 1, 2024
257b12b
Update query snapshots
github-actions[bot] Oct 1, 2024
b81a36d
Merge branch 'master' into ch-24.3
fuziontech Oct 9, 2024
859e43b
lots of fixes
fuziontech Oct 11, 2024
5f86737
Merge branch 'master' into ch-24.3
fuziontech Oct 11, 2024
386412b
Update query snapshots
github-actions[bot] Oct 11, 2024
a7ae8e9
Update query snapshots
github-actions[bot] Oct 11, 2024
4c16ffe
Update query snapshots
github-actions[bot] Oct 11, 2024
9859020
Update query snapshots
github-actions[bot] Oct 11, 2024
364df6f
Update query snapshots
github-actions[bot] Oct 11, 2024
c71b964
Update query snapshots
github-actions[bot] Oct 11, 2024
a968873
clean up ancient configs and disable analyzer
fuziontech Oct 11, 2024
a608454
checkpoint
fuziontech Oct 11, 2024
9138acb
Merge branch 'master' into ch-24.3
fuziontech Oct 11, 2024
a7b7b3f
merge master
fuziontech Oct 11, 2024
512aeeb
Update query snapshots
github-actions[bot] Oct 11, 2024
59d2996
Update query snapshots
github-actions[bot] Oct 11, 2024
d28d3ea
Update query snapshots
github-actions[bot] Oct 11, 2024
3ce65c4
Update query snapshots
github-actions[bot] Oct 11, 2024
d25f6af
Update query snapshots
github-actions[bot] Oct 11, 2024
a46ec55
more fixes
fuziontech Oct 11, 2024
57da9aa
merge master
fuziontech Oct 11, 2024
e1669d9
Update query snapshots
github-actions[bot] Oct 11, 2024
2f63510
Update query snapshots
github-actions[bot] Oct 12, 2024
4e984ad
Update query snapshots
github-actions[bot] Oct 12, 2024
f652d08
Update query snapshots
github-actions[bot] Oct 12, 2024
c1237ac
Update query snapshots
github-actions[bot] Oct 12, 2024
47ec0ae
Update query snapshots
github-actions[bot] Oct 12, 2024
85ccccf
fix broken tests
fuziontech Oct 12, 2024
05005ca
Merge branch 'ch-24.3' of https://github.com/PostHog/posthog into ch-…
fuziontech Oct 12, 2024
123189a
Merge branch 'master' into ch-24.3
fuziontech Oct 14, 2024
6e0663f
maybe?
fuziontech Oct 14, 2024
429302d
Update query snapshots
github-actions[bot] Oct 14, 2024
57d25e9
test?
fuziontech Oct 14, 2024
cd0c0cf
Update query snapshots
github-actions[bot] Oct 14, 2024
54b1a4a
fix bad test
fuziontech Oct 16, 2024
45964f2
Merge branch 'ch-24.3' of https://github.com/PostHog/posthog into ch-…
fuziontech Oct 16, 2024
04c65b6
Merge branch 'master' into ch-24.3
fuziontech Oct 18, 2024
d7332d7
Merge branch 'master' into ch-24.3
fuziontech Oct 21, 2024
a5779c5
Merge branch 'ch-24.3' of https://github.com/PostHog/posthog into ch-…
fuziontech Oct 21, 2024
5ee384c
Merge branch 'master' into ch-24.3
fuziontech Oct 22, 2024
092f51c
test fixes
fuziontech Oct 22, 2024
0806092
fix for xp tests against CH funnel
fuziontech Oct 23, 2024
fbabfe9
Merge branch 'master' into ch-24.3
fuziontech Oct 29, 2024
879d929
snapshot merge
aspicer Nov 6, 2024
f1f502f
Update query snapshots
github-actions[bot] Nov 6, 2024
ef475a2
Update query snapshots
github-actions[bot] Nov 6, 2024
6b5bf4b
trend test order
aspicer Nov 7, 2024
109f0c4
Merge branch 'ch-24.3' of github.com:PostHog/posthog into ch-24.3
aspicer Nov 7, 2024
b8bc040
merge
aspicer Nov 7, 2024
5fc9138
remove clickhouse stuff from tests
aspicer Nov 7, 2024
509fd77
Merge branch 'aspicer/strict' into ch-24.3
aspicer Nov 7, 2024
411c298
Update query snapshots
github-actions[bot] Nov 7, 2024
952ade3
Update query snapshots
github-actions[bot] Nov 7, 2024
2d653c1
Merge branch 'master' into ch-24.3
fuziontech Nov 12, 2024
7f17520
fix person query
fuziontech Nov 12, 2024
542936b
Merge branch 'master' into ch-24.3
fuziontech Nov 12, 2024
ae93ee5
fix clickhouse experiments tests (fix)
fuziontech Nov 12, 2024
7e24083
Merge branch 'master' into ch-24.3
fuziontech Nov 13, 2024
a8c9690
Merge branch 'master' into ch-24.3
fuziontech Nov 13, 2024
deccce4
just disable experimental analyzer for funnels
fuziontech Nov 14, 2024
2f2cb91
revert ee/clickhouse/views/test/test_clickhouse_experiments.py to master
fuziontech Nov 14, 2024
43594f1
Merge branch 'master' into ch-24.3
fuziontech Nov 14, 2024
1730ce4
Update query snapshots
github-actions[bot] Nov 14, 2024
963b63e
Update query snapshots
github-actions[bot] Nov 14, 2024
06ca623
fix: test_funnel_cohort_breakdown and test_funnel_cohort_breakdown_ma…
Daesgar Nov 14, 2024
9e1b8d2
Update query snapshots
github-actions[bot] Nov 14, 2024
28b8fe3
Update query snapshots
github-actions[bot] Nov 14, 2024
a7944d6
fix: disable analyzer for FUNNEL_PERSONS_BY_STEP_SQL
Daesgar Nov 14, 2024
54ce4e7
Update query snapshots
github-actions[bot] Nov 14, 2024
6ef82ad
Update query snapshots
github-actions[bot] Nov 14, 2024
d874e08
fix: use version 24.8 for all backend tests
Daesgar Nov 14, 2024
6dda214
chore: run tests only on 24.8 version
Daesgar Nov 14, 2024
34370ca
max(max_steps)
fuziontech Nov 14, 2024
00511db
Update query snapshots
github-actions[bot] Nov 14, 2024
98f97ea
Update query snapshots
github-actions[bot] Nov 14, 2024
fbca132
fix test_clickhouse_experiment_secondary_results
fuziontech Nov 14, 2024
fcf5500
Update query snapshots
github-actions[bot] Nov 14, 2024
ee60aa5
just disable query analyzer for this query
fuziontech Nov 15, 2024
6c4f0ae
remove setting in FUNNEL_PERSONS_BY_STEP
fuziontech Nov 15, 2024
bdb6aa5
ambr test
fuziontech Nov 15, 2024
da51adb
merge resolve
fuziontech Nov 15, 2024
f043bc2
Update query snapshots
github-actions[bot] Nov 15, 2024
62236c3
Update query snapshots
github-actions[bot] Nov 15, 2024
35997c5
Update query snapshots
github-actions[bot] Nov 15, 2024
356b3ff
Update query snapshots
github-actions[bot] Nov 15, 2024
53b18c6
max(max_steps) snapshot
fuziontech Nov 15, 2024
5c9f874
add back FUNNEL_PERSONS_BY_STEP_SQL disable analyzer
fuziontech Nov 15, 2024
bb6ec44
Update query snapshots
github-actions[bot] Nov 15, 2024
680d07b
Update query snapshots
github-actions[bot] Nov 15, 2024
fdaeb76
remove restriction on analyzer again on FUNNEL_PERSONS_STEP_SQL
fuziontech Nov 16, 2024
fc16d7e
Update query snapshots
github-actions[bot] Nov 16, 2024
f889472
maybe???
fuziontech Nov 16, 2024
74bd615
Update query snapshots
github-actions[bot] Nov 16, 2024
7b59b2d
Merge branch 'master' into ch-24.3
fuziontech Nov 16, 2024
c2176eb
Merge branch 'master' into ch-24.3
fuziontech Nov 21, 2024
5a80444
Merge branch 'master' into ch-24.3
fuziontech Nov 22, 2024
bc0adae
update to 24.8.7.41 to be more current
fuziontech Nov 22, 2024
73a7c3f
Merge branch 'master' into ch-24.3
fuziontech Nov 25, 2024
ee8ece7
update the select statement for the raw_sessions table
fuziontech Nov 25, 2024
5f71bf7
Merge branch 'master' into ch-24.3
fuziontech Nov 25, 2024
fdeabfc
Merge branch 'master' into ch-24.3
fuziontech Nov 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/run-backend-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ runs:

- name: Upload updated timing data as artifacts
uses: actions/upload-artifact@v4
if: ${{ inputs.person-on-events != 'true' && inputs.clickhouse-server-image == 'clickhouse/clickhouse-server:23.12.6.19' }}
if: ${{ inputs.person-on-events != 'true' && inputs.clickhouse-server-image == 'clickhouse/clickhouse-server:24.8.7.41' }}
with:
name: timing_data-${{ inputs.segment }}-${{ inputs.group }}
path: .test_durations
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-backend-update-test-timing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ jobs:
group: 1
token: ${{ secrets.POSTHOG_BOT_GITHUB_TOKEN }}
python-version: '3.11.9'
clickhouse-server-image: 'clickhouse/clickhouse-server:23.12.6.19'
clickhouse-server-image: 'clickhouse/clickhouse-server:24.8.7.41'
segment: 'FOSS'
person-on-events: false

- name: Upload updated timing data as artifacts
uses: actions/upload-artifact@v4
if: ${{ inputs.person-on-events != 'true' && inputs.clickhouse-server-image == 'clickhouse/clickhouse-server:23.12.6.19' }}
if: ${{ inputs.person-on-events != 'true' && inputs.clickhouse-server-image == 'clickhouse/clickhouse-server:24.8.7.41' }}
with:
name: timing_data-${{ inputs.segment }}-${{ inputs.group }}
path: .test_durations
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci-backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.11.9']
clickhouse-server-image: ['clickhouse/clickhouse-server:23.12.6.19']
clickhouse-server-image: ['clickhouse/clickhouse-server:24.8.7.41']
segment: ['Core']
person-on-events: [false, true]
# :NOTE: Keep concurrency and groups in sync
Expand All @@ -243,19 +243,19 @@ jobs:
include:
- segment: 'Temporal'
person-on-events: false
clickhouse-server-image: 'clickhouse/clickhouse-server:23.12.6.19'
clickhouse-server-image: 'clickhouse/clickhouse-server:24.8.7.41'
python-version: '3.11.9'
concurrency: 3
group: 1
- segment: 'Temporal'
person-on-events: false
clickhouse-server-image: 'clickhouse/clickhouse-server:23.12.6.19'
clickhouse-server-image: 'clickhouse/clickhouse-server:24.8.7.41'
python-version: '3.11.9'
concurrency: 3
group: 2
- segment: 'Temporal'
person-on-events: false
clickhouse-server-image: 'clickhouse/clickhouse-server:23.12.6.19'
clickhouse-server-image: 'clickhouse/clickhouse-server:24.8.7.41'
python-version: '3.11.9'
concurrency: 3
group: 3
Expand Down Expand Up @@ -326,7 +326,7 @@ jobs:
strategy:
fail-fast: false
matrix:
clickhouse-server-image: ['clickhouse/clickhouse-server:23.12.6.19']
clickhouse-server-image: ['clickhouse/clickhouse-server:24.8.7.41']
if: needs.changes.outputs.backend == 'true'
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ services:
# Note: please keep the default version in sync across
# `posthog` and the `charts-clickhouse` repos
#
image: ${CLICKHOUSE_SERVER_IMAGE:-clickhouse/clickhouse-server:23.12.6.19}
image: ${CLICKHOUSE_SERVER_IMAGE:-clickhouse/clickhouse-server:24.8.7.41}
restart: on-failure

zookeeper:
Expand Down
1 change: 1 addition & 0 deletions docker-compose.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ services:
service: clickhouse
ports:
- '8123:8123'
- '8443:8443'
- '9000:9000'
- '9440:9440'
- '9009:9009'
Expand Down
Loading
Loading