feat: start of clickhouse server version bump to 24.8 #25189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuziontech
force-pushed
the
ch-24.3
branch
2 times, most recently
from
f2a07f1 to
a447bd7
Compare
fuziontech
changed the title
fuziontech
changed the title
fuziontech
changed the title
* master: (66 commits) feat: display line context in stack frames (#26254) fix(experiments HogQL): fix funnels filter in prepare_query (#26327) fix(hogql): Support parsing dw properties with nested values (#26321) fix(err): include raw js frame on frame content in pg (#26326) fix: mobile project settings network labels (#26318) fix: reduce perms from 3 to 2 for test perf (#26322) feat: add new alerts feature for product_analytics (#26320) feat(experiments): Enable holdouts for everyone (#26301) feat: reorg inspector list rows (#26243) feat: Split-up batch exports into sync and async (#26294) fix(data-warehouse): Fix custom series colors in chart tooltips (#26310) feat(cdp): adjust zapier destination description (#26313) fix(insights): prevent race condition (#26265) feat(product-assistant): evaluation pipeline (#26179) chore: session replay project config for mobile - what is possible (#26289) feat(cdp): make hash functions return null if the input is null (#26311) feat(err): cymbal for all teams (#26312) feat(hogql): Allow breakdowns for lazy-joined tables (#26302) feat: create events table to store last 7 days of data (#26239) chore: Bump batch exports start jitter (#26278) ...
tkaemming
approved these changes
Nov 25, 2024
|
Word to the wise @fuziontech @tkaemming @Daesgar - you might run into ClickHouse/ClickHouse#68239 upgrading to 24.8. This was fixed in 24.9. |
|
@macobo you are my hero - thank you. We've been digging into why CH CPU has been 📈 since the upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In flight
Problem
We need to upgrade CH versions that are deployed, this is the first step to make sure things don't break
Changes
Deployment plan
This is slightly tricky because we will have a period of time where we will error on queries due to query <> DB version incompatibilities. We will manage this by moving quickly.
Tests to fix ✅
400responses👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
With a lot of tests