Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding-templates): create actions from within the iframe #24825

Merged
merged 19 commits into from
Sep 11, 2024

Conversation

raquelmsmith
Copy link
Member

@raquelmsmith raquelmsmith commented Sep 5, 2024

Problem

For #23065

Now that we have an iframe to work with an a UI for the variables, we need to communicate with the iFrame to set up the actions, and set them as the template variables.

Changes

It works!!

Screen.Recording.2024-09-09.at.1.48.36.PM.mov
  • Show elements when selecting from site
  • Set action name from template
  • Create action without form (form is attached to toolbar, which we hide)
  • Let people say if they want to include the element text, href, and page url
  • Relay newly created action info back to template variable thing
  • Show action info in template form
  • Handle duplicately-named actions
  • Fix dashboard creation not working
  • Make sure people can use this if they haven't ingested any snippet events (they can set custom event names and, in a coming PR, use page URL)
    • Arc 2024-09-09 21 00 45

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@raquelmsmith raquelmsmith marked this pull request as ready for review September 6, 2024 21:39
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Size Change: +2.35 kB (+0.21%)

Total Size: 1.1 MB

Filename Size Change
frontend/dist/toolbar.js 1.1 MB +2.35 kB (+0.21%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (wasn't pushed!)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@zlwaterfield zlwaterfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is really awesome. Nice work. :) The code looks good, although I don't understand much of it.

I can't get my ingestion to work locally ATM, so I didn't test. I can test again tomorrow once I get the ingestion working.

@raquelmsmith raquelmsmith merged commit b865cea into master Sep 11, 2024
97 checks passed
@raquelmsmith raquelmsmith deleted the feat/onboarding-tempaltes-hook-up-iframe-toolbar branch September 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants