-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(onboarding-templates): create actions from within the iframe #24825
feat(onboarding-templates): create actions from within the iframe #24825
Conversation
Size Change: +2.35 kB (+0.21%) Total Size: 1.1 MB
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
…tps://github.com/PostHog/posthog into feat/onboarding-tempaltes-hook-up-iframe-toolbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is really awesome. Nice work. :) The code looks good, although I don't understand much of it.
I can't get my ingestion to work locally ATM, so I didn't test. I can test again tomorrow once I get the ingestion working.
Problem
For #23065
Now that we have an iframe to work with an a UI for the variables, we need to communicate with the iFrame to set up the actions, and set them as the template variables.
Changes
It works!!
Screen.Recording.2024-09-09.at.1.48.36.PM.mov
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?