feat(onboarding-templates): allow someone to select pageview as variable #24899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I need to rebase this on master once #24825 goes out. It's not actually 700 lines! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Size Change: +475 B (+0.04%) Total Size: 1.1 MB ℹ️ View Unchanged
|
raquelmsmith
force-pushed
the
feat/onboarding-templates-pageview-variabe
branch
from
ef0bc19 to
206551a
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
zlwaterfield
approved these changes
Sep 12, 2024
| @@ -255,6 +279,9 @@ export const iframedToolbarBrowserLogic = kea<iframedToolbarBrowserLogicType>([ | |||
| actions.setNewActionName(null) | |||
| actions.disableElementSelector() | |||
| return | |||
| case PostHogAppToolbarEvent.PH_TOOLBAR_NAVIGATED: | |||
| // remove leading / from path | |||
| return actions.setCurrentPath(payload.path.replace(/^\/+/, '')) | |||
There was a problem hiding this comment.
This function returns void so technically you should be doing something like this:
Suggested change
| return actions.setCurrentPath(payload.path.replace(/^\/+/, '')) | |
| actions.setCurrentPath(payload.path.replace(/^\/+/, '')) | |
| return void |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For #23065
A common event in dashboards/insights is a pageview. Eg signup page viewed -> clicked signup button.
Additionally, sometimes these events happen on different domains - eg posthog.com and us.posthog.com.
Changes
Adds a url navigator, constrained to URLs that have seen ingested events. Shows current iframe URL in the URL input. Lets someone use a page URL as the template variable.
Screen.Recording.2024-09-10.at.4.35.29.PM.mov
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?