feat(insights): Add cumulative retention #24240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was tertiary but that is confusing - also some alignment of the side action was off
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated10 snapshot changes in total. 0 added, 10 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated8 snapshot changes in total. 0 added, 8 modified, 0 deleted:
Triggered by this commit. |
# Conflicts: # frontend/__snapshots__/scenes-app-insights--retention-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown-edit--dark.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown-edit--light.png # frontend/__snapshots__/scenes-app-insights--retention-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-edit--light.png
webjunkie
force-pushed
the
feature/retention-cumulative
branch
from
64f743e to
aadb03a
Compare
📸 UI snapshots have been updated15 snapshot changes in total. 0 added, 15 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
thmsobrmlr
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Great, thank you! Leaving a couple of comments:
- The new property can probably be added to the "frontend only" props here https://github.com/PostHog/posthog/blob/master/frontend/src/scenes/insights/utils/compareInsightQuery.ts#L53-L66, so that it doesn't trigger a new query request.
- The UI gets a bit squished for me. We might want to use the double-row layout or the advanced options menu here as well.
- I think "rolling retention" needs some more info to be understandable for the user
| @@ -436,6 +436,7 @@ export const retentionFilterToQuery = (filters: Partial<RetentionFilterType>): R | |||
| targetEntity: sanitizeRetentionEntity(filters.target_entity), | |||
| period: filters.period, | |||
| showMean: filters.show_mean, | |||
| cumulative: filters.cumulative, | |||
There was a problem hiding this comment.
This needs to be added to the backend side filter_to_query function as well.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #23661
Changes
Just added a flag that is UI only and sums the values.
Named in UI "Rolling retention". Or any better ideas?
Does this work well for both Cloud and self-hosted?
How did you test this code?