fix: rolling retention #24926
Merged
fix: rolling retention #24926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
| @@ -35,7 +35,7 @@ export function RetentionTable({ inCardView = false }: { inCardView?: boolean }) | |||
|
|
|||
| {showMean && tableRows.length > 0 ? ( | |||
| <tr className="border-b" key={-1}> | |||
| {range(0, tableRows[0].length).map((columnIndex) => ( | |||
| {range(0, tableRows[0].length - 1).map((columnIndex) => ( | |||
There was a problem hiding this comment.
just missing why you're doing -1 here + the check on line 50 if (columnIndex < row.length - 1) {
There was a problem hiding this comment.
noticed you increment intervals_from_base but only happens for cumulative
There was a problem hiding this comment.
Good catch - I just blindly reverted the FE changes from #24240 but this seems like it was an unrelated bug fix.
The means seem like they're properly working now.
anirudhpillai
approved these changes
Sep 12, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rolling retention wasn't calculated correctly
https://posthoghelp.zendesk.com/agent/tickets/17978
https://posthoghelp.zendesk.com/agent/tickets/18002
Changes
Convert the calculation to the backend and calculate it correctly.
Normal
Rolling
Sep 2 Cohort Breakout
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Wrote a test, manually verified.