fix(persons): Display error when person API fails #24220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
webjunkie
force-pushed
the
fix/person-detail-error
branch
from
499c0d8 to
c3fce78
Compare
thmsobrmlr
approved these changes
Aug 7, 2024
|
Related PR adding an error reducer to kea-loaders: keajs/kea-loaders#26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If person API responds with an error, the page shows 404
Fixes #23671
Changes
It would be nice to get the failure state in KEA for all loaders in general, but to quick fix it I'm using the
loadPersonFailureto get the error.How did you test this code?
Tested locally with simulated error from backend.