fix(persons): Display error when person API fails (#24220)

PostHog · Aug 7, 2024 · 9481490 · 9481490
1 parent fc8953c
commit 9481490
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/frontend/src/scenes/persons/PersonScene.tsx b/frontend/src/scenes/persons/PersonScene.tsx
@@ -101,6 +101,7 @@ export function PersonScene(): JSX.Element | null {
         feedEnabled,
         person,
         personLoading,
+        personError,
         currentTab,
         splitMergeModalShown,
         urlId,
@@ -113,6 +114,9 @@ export function PersonScene(): JSX.Element | null {
     const { groupsEnabled } = useValues(groupsAccessLogic)
     const { currentTeam } = useValues(teamLogic)
 
+    if (personError) {
+        throw new Error(personError)
+    }
     if (!person) {
         return personLoading ? <SpinnerOverlay sceneLevel /> : <NotFound object="Person" />
     }

diff --git a/frontend/src/scenes/persons/personsLogic.tsx b/frontend/src/scenes/persons/personsLogic.tsx
@@ -202,6 +202,15 @@ export const personsLogic = kea<personsLogicType>([
             loadPerson: () => null,
             setPerson: (_, { person }): PersonType | null => person,
         },
+        personError: [
+            null as string | null,
+            {
+                loadPerson: () => null,
+                setPerson: () => null,
+                loadPersonUUID: () => null,
+                loadPersonFailure: (_, { error }) => error,
+            },
+        ],
         distinctId: [
             null as string | null,
             {