feat(insights): keep rolling date range popover open #24132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +46 B (0%) Total Size: 1.07 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As @annikaschmid mentions here https://posthog.slack.com/archives/C045L1VEG87/p1722510164730109 it's quite annoying that the rolling date filter closes when incrementing or decrementing dates. That already would be enough, but I think this might also be why the Cypress tests here #24050 are failing (no idea why this would come up with my changes 🤷 ).
Changes
Keeps the popover open until the user clicks outside.
How did you test this code?
Tried locally