feat(insights): keep rolling date range popover open (#24132)

PostHog · Aug 1, 2024 · cb55c15 · cb55c15
1 parent ceccb49
commit cb55c15
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/frontend/src/lib/components/DateFilter/DateFilter.tsx b/frontend/src/lib/components/DateFilter/DateFilter.tsx
@@ -180,7 +180,7 @@ export function DateFilter({
                         dateRangeFilterLabel={isFixedDateMode ? 'Last' : undefined}
                         selected={isRollingDateRange}
                         onChange={(fromDate) => {
-                            setDate(fromDate, '')
+                            setDate(fromDate, '', true)
                         }}
                         makeLabel={makeLabel}
                         popover={{

diff --git a/frontend/src/lib/components/DateFilter/dateFilterLogic.ts b/frontend/src/lib/components/DateFilter/dateFilterLogic.ts
@@ -23,7 +23,11 @@ export const dateFilterLogic = kea<dateFilterLogicType>([
         openFixedDate: true,
         close: true,
         applyRange: true,
-        setDate: (dateFrom: string | null, dateTo: string | null) => ({ dateFrom, dateTo }),
+        setDate: (dateFrom: string | null, dateTo: string | null, keepPopoverOpen = false) => ({
+            dateFrom,
+            dateTo,
+            keepPopoverOpen,
+        }),
         setRangeDateFrom: (range: Dayjs | null) => ({ range }),
         setRangeDateTo: (range: Dayjs | null) => ({ range }),
     }),
@@ -44,7 +48,7 @@ export const dateFilterLogic = kea<dateFilterLogicType>([
                 openFixedRange: () => true,
                 openDateToNow: () => true,
                 openFixedDate: () => true,
-                setDate: () => false,
+                setDate: (_, { keepPopoverOpen }) => keepPopoverOpen,
                 close: () => false,
             },
         ],