refactor(insights): remove filter based card content #24050

thmsobrmlr · 2024-07-29T13:53:22Z

Problem

We have feature flag query-based-dashboard-cards that replaces filter based cards with their query based equivalent in most cases (i.e. in contexts where the feature flag works). We'd like to remove the legacy code and roll out query based cards for all occurances.

Changes

Removes the legacy FilterBasedCard component.
Fixes a bug where an insight with many breakdown values would show the "Load more breakdown values..." in the card view.

How did you test this code?

CI run and clicking around

github-actions · 2024-07-29T15:22:58Z

Size Change: +2 B (0%)

Total Size: 1.07 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	1.07 MB	+2 B (0%)

_{compressed-size-action}

posthog-bot · 2024-07-29T15:24:57Z

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

chromium: 0 added, 6 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-29T15:44:14Z

📸 UI snapshots have been updated

52 snapshot changes in total. 0 added, 52 modified, 0 deleted:

chromium: 0 added, 52 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

thmsobrmlr · 2024-07-29T15:52:52Z

frontend/__snapshots__/exporter-exporter--lifecycle-insight--dark.png

I did manually export one insight of each kind and compared it against the previous version - couldn't replicate the shrinking as seen in these snapshot tests e.g. this is the lifecycle insight with the new query based card:

posthog-bot · 2024-07-30T07:21:30Z

📸 UI snapshots have been updated

52 snapshot changes in total. 0 added, 52 modified, 0 deleted:

chromium: 0 added, 52 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-30T07:39:44Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-30T07:57:50Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-30T14:44:36Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-30T15:02:38Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-30T15:20:51Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (wasn't pushed!)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-01T12:03:17Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-08-01T12:21:59Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

cypress/e2e/insights-date-picker.cy.ts

# Conflicts: # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--dark.png

thmsobrmlr · 2024-08-02T08:13:53Z

cypress/e2e/insights-date-picker.cy.ts

 import { urls } from 'scenes/urls'

 describe('insights date picker', () => {
    beforeEach(() => {
        cy.visit(urls.insightNew())
+        cy.waitForNetworkIdle(300)


This was much easier than mocking requests to /query/ and /query/:queryId, which I couldn't get working.

skoob13

The PR looks good! I didn't notice any problems with cards, exports, or embeddings.

thmsobrmlr added 4 commits July 29, 2024 15:52

wip

e06088e

support notebook editing state

84e90bd

wip

cde9313

funnel styles

88dd5af

thmsobrmlr force-pushed the remove-filter-based-card-3 branch from bda3ca9 to 88dd5af Compare July 29, 2024 15:12

PostHog deleted a comment from posthog-bot Jul 29, 2024

PostHog deleted a comment from github-actions bot Jul 29, 2024

thmsobrmlr commented Jul 29, 2024

View reviewed changes

thmsobrmlr added 2 commits July 29, 2024 18:30

fix funnel single step

110c9d5

move query based insight one level out

eb73f1c

thmsobrmlr force-pushed the remove-filter-based-card-3 branch from 42e387e to eb73f1c Compare July 30, 2024 07:02

github-actions bot added 2 commits July 30, 2024 07:20

Update UI snapshots for chromium (1)

82a4618

Update UI snapshots for chromium (2)

dc550bc

Update UI snapshots for chromium (1)

09e54a8

Update UI snapshots for chromium (1)

de34965

PostHog deleted a comment from posthog-bot Jul 30, 2024

Update UI snapshots for chromium (1)

5e956c3

dont snapshot all exporter stories (flappy)

487c412

github-actions bot and others added 6 commits July 30, 2024 15:37

Update UI snapshots for chromium (1)

35dbcec

Merge branch 'master' into remove-filter-based-card-3

08a02e4

try a hacky fix for e2e tests

29d1809

also add intercepts

311436b

why does this work locally?!

0597d23

Update UI snapshots for chromium (1)

4f66284

Update UI snapshots for chromium (1)

c830a80

thmsobrmlr mentioned this pull request Aug 1, 2024

feat(insights): keep rolling date range popover open #24132

Merged

thmsobrmlr added 3 commits August 1, 2024 15:34

add .cy to e2e test file name

7a3fedb

use a blunt hammer to get this working

98584ed

remove intercepts and color hack

25f7bcd

thmsobrmlr commented Aug 1, 2024

View reviewed changes

cypress/e2e/insights-date-picker.cy.ts Outdated Show resolved Hide resolved

thmsobrmlr added 2 commits August 2, 2024 10:08

Merge branch 'master' into remove-filter-based-card-3

3159251

# Conflicts: # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--dark.png

try 300ms

dde2f15

thmsobrmlr commented Aug 2, 2024

View reviewed changes

thmsobrmlr marked this pull request as ready for review August 2, 2024 08:17

thmsobrmlr requested a review from a team August 2, 2024 08:17

thmsobrmlr changed the title ~~refactor(insights): remove filter based card content (take 3)~~ refactor(insights): remove filter based card content Aug 2, 2024

skoob13 approved these changes Aug 2, 2024

View reviewed changes

thmsobrmlr merged commit ea98024 into master Aug 5, 2024
101 checks passed

thmsobrmlr deleted the remove-filter-based-card-3 branch August 5, 2024 07:14

thmsobrmlr mentioned this pull request Aug 5, 2024

refactor(insights): remove filter based card content #23886

Closed

12 tasks

silentninja pushed a commit to silentninja/posthog that referenced this pull request Aug 8, 2024

refactor(insights): remove filter based card content (PostHog#24050)

205de83

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(insights): remove filter based card content #24050

refactor(insights): remove filter based card content #24050

thmsobrmlr commented Jul 29, 2024 •

edited

Loading

github-actions bot commented Jul 29, 2024 •

edited

Loading

posthog-bot commented Jul 29, 2024

posthog-bot commented Jul 29, 2024

thmsobrmlr Jul 29, 2024

posthog-bot commented Jul 30, 2024

posthog-bot commented Jul 30, 2024

posthog-bot commented Jul 30, 2024

posthog-bot commented Jul 30, 2024

posthog-bot commented Jul 30, 2024

posthog-bot commented Jul 30, 2024

posthog-bot commented Aug 1, 2024

posthog-bot commented Aug 1, 2024

thmsobrmlr Aug 2, 2024

skoob13 left a comment

refactor(insights): remove filter based card content #24050

refactor(insights): remove filter based card content #24050

Conversation

thmsobrmlr commented Jul 29, 2024 • edited Loading

Problem

Changes

How did you test this code?

github-actions bot commented Jul 29, 2024 • edited Loading

posthog-bot commented Jul 29, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 29, 2024

📸 UI snapshots have been updated

thmsobrmlr Jul 29, 2024

Choose a reason for hiding this comment

posthog-bot commented Jul 30, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 30, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 30, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 30, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 30, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 30, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 1, 2024

📸 UI snapshots have been updated

posthog-bot commented Aug 1, 2024

📸 UI snapshots have been updated

thmsobrmlr Aug 2, 2024

Choose a reason for hiding this comment

skoob13 left a comment

Choose a reason for hiding this comment

thmsobrmlr commented Jul 29, 2024 •

edited

Loading

github-actions bot commented Jul 29, 2024 •

edited

Loading