refactor(insights): simplify "save insight" #24047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
force-pushed
the
refactor-save-insight
branch
from
708b959 to
7b9ee75
Compare
|
Size Change: +40 B (0%) Total Size: 1.07 MB ℹ️ View Unchanged
|
|
@thmsobrmlr saving an insight works well, but there is a bug with saving a data warehouse insight. I can't reproduce it on master. Reproduction
Steps to reproduce
|
|
Thanks for catching this @skoob13! I think it's fixed now. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
thmsobrmlr
added a commit
that referenced
this pull request
Jul 30, 2024
This reverts commit 31bf450.
This was referenced Jul 30, 2024
silentninja
pushed a commit
to silentninja/posthog
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Changes
Builds upon #24024 to and moves the
saveInsightaction into the insightLogic, so that we don't need to do the dance where we first usesetInsightto update the insight in insightLogic with the current query and then perform the save action on the insightsLogic.Contrary to the approach of passing in the query in the action as done in #24024, I found a way for kea to accept circular dependencies between
insightLogicandinsightDataLogic, so that we can now use the current query natively ininsightLogic.Doing this refactor now to get rid of filters in
insightDataLogic.How did you test this code?
Saved a new and existing insight