refactor(insights): simplify "save insight" #24093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ef138d8.
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
anirudhpillai
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24086.
The original PR #24047 was reverted after we had reports that insights within notebooks were failing https://posthog.slack.com/archives/C0368RPHLQH/p1722362575815759 . We didn't see this issue during our testing since the logic can be mounted depending on navigation order (e.g. it is mounted when looking at a notebook on the insight page).
Added a fix for the issue here.