refactor(insights): simplify "save as ..." #24024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
thmsobrmlr
force-pushed
the
refactor-save-as
branch
from
aff0263 to
beb89c0
Compare
thmsobrmlr
force-pushed
the
refactor-save-as
branch
from
d42caa0 to
7288fb8
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
thmsobrmlr
commented
Jul 26, 2024
| @@ -87,7 +89,12 @@ export const insightLogic = kea<insightLogicType>([ | |||
| insight, | |||
| options, | |||
| }), | |||
| saveAsNamingSuccess: (name: string, redirectToViewMode?: boolean) => ({ name, redirectToViewMode }), | |||
| saveAs: (query: Node, redirectToViewMode?: boolean) => ({ query, redirectToViewMode }), | |||
| saveAsConfirmation: (name: string, query: Node, redirectToViewMode?: boolean) => ({ | |||
There was a problem hiding this comment.
Renaming from saveAsSuccess top saveAsConfirmation. This action is triggered after selecting the desired name in a LemonModal dialog. The Success suffix is usually reserved for kea-loader generated actions.
thmsobrmlr
commented
Jul 26, 2024
| onSubmit: async ({ insightName }) => actions.saveAsNamingSuccess(insightName, redirectToViewMode), | ||
| }) | ||
| }, | ||
| saveAsNamingSuccess: ({ name, redirectToViewMode }) => { |
There was a problem hiding this comment.
This whole thing happening in the listener is what we get rid of here.
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
skoob13
approved these changes
Jul 29, 2024
silentninja
pushed a commit
to silentninja/posthog
that referenced
this pull request
Aug 8, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Changes
Moves the
saveAsaction to the insightLogic and passes in the current query, so that we don't need to do the dance where we first usesetInsightto update the insight in insightLogic with the current query and then perform the "save as" action on the insightsLogic. Doing this refactor now to get rid of filters ininsightDataLogic.How did you test this code?
Created an insight, made some changes, then used "save as" to save the changed version under another name