fix(funnels): Don't allow persons modal in funnel trends if unavailable #23759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
thmsobrmlr
approved these changes
Jul 16, 2024
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
skoob13
pushed a commit
that referenced
this pull request
Jul 22, 2024
silentninja
pushed a commit
to silentninja/posthog
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently don't support persons list calculation for funnels aggregated by "Unique sessions", or specifically by something other than "Unique users". This was properly reflected in the persons modal being disabled in the funnel steps view – but not in the historical trends view, resulting in plain errors (see ZEN-15808).
Changes
This removes the false ability to open the persons modal, preventing the pointless experience.
It'd also be good to add support for the persons list in that case – created issue #23758 on this.
How did you test this code?
Manual creation of a funnel.