fix(funnels): Don't allow persons modal in funnel trends if unavailab…

…le (#23759)
PostHog · Jul 18, 2024 · 2a04631 · 2a04631
1 parent 6f8c23d
commit 2a04631
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/frontend/__snapshots__/scenes-other-onboarding--onboarding-billing--light.png b/frontend/__snapshots__/scenes-other-onboarding--onboarding-billing--light.png
diff --git a/frontend/src/scenes/funnels/FunnelLineGraph.tsx b/frontend/src/scenes/funnels/FunnelLineGraph.tsx
@@ -11,6 +11,7 @@ import { isInsightQueryNode } from '~/queries/utils'
 import { ChartParams, GraphDataset, GraphType } from '~/types'
 
 import { funnelDataLogic } from './funnelDataLogic'
+import { funnelPersonsModalLogic } from './funnelPersonsModalLogic'
 
 const LineGraphWrapper = ({ inCardView, children }: { inCardView?: boolean; children: JSX.Element }): JSX.Element => {
     if (inCardView) {
@@ -23,16 +24,18 @@ const LineGraphWrapper = ({ inCardView, children }: { inCardView?: boolean; chil
 export function FunnelLineGraph({
     inCardView,
     inSharedMode,
-    showPersonsModal = true,
+    showPersonsModal: showPersonsModalProp = true,
 }: Omit<ChartParams, 'filters'>): JSX.Element | null {
     const { insightProps } = useValues(insightLogic)
     const { indexedSteps, aggregationTargetLabel, incompletenessOffsetFromEnd, interval, querySource, insightData } =
         useValues(funnelDataLogic(insightProps))
+    const { canOpenPersonModal } = useValues(funnelPersonsModalLogic(insightProps))
 
     if (!isInsightQueryNode(querySource)) {
         return null
     }
 
+    const showPersonsModal = canOpenPersonModal && showPersonsModalProp
     const aggregationGroupTypeIndex = querySource.aggregation_group_type_index
 
     return (