chore(deps): Upgrade to Django 5

ee/api/test/test_action.py

@@ -1,7 +1,7 @@
+import datetime
 from typing import cast
 
 import pytest
-from django.utils import timezone
 from rest_framework import status
 
 from posthog.cloud_utils import is_cloud
@@ -19,7 +19,7 @@ def test_create_action_update_delete_tags(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
             key="key_123",
             plan="enterprise",
-            valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7),
+            valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7),
         )
 
         response = self.client.post(f"/api/projects/{self.team.id}/actions/", data={"name": "user signed up"})
@@ -47,7 +47,7 @@ def test_create_action_with_tags(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
             key="key_123",
             plan="enterprise",
-            valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7),
+            valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7),
         )
 
         response = self.client.post(
@@ -66,7 +66,7 @@ def test_actions_does_not_nplus1(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
             key="key_123",
             plan="enterprise",
-            valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7),
+            valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7),
         )
 
         # Ensure the cloud check is cached to not affect the number of queries
@@ -91,7 +91,7 @@ def test_actions_no_duplicate_tags(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
             key="key_123",
             plan="enterprise",
-            valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7),
+            valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7),
         )
         response = self.client.post(
             f"/api/projects/{self.team.id}/actions/",

ee/api/test/test_dashboard.py

@@ -1,6 +1,6 @@
+import datetime
 from typing import cast
 
-from django.utils import timezone
 from rest_framework import status
 
 from ee.api.test.base import APILicensedTest
@@ -232,7 +232,7 @@ def test_dashboard_no_duplicate_tags(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
             key="key_123",
             plan="enterprise",
-            valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7),
+            valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7),
         )
         dashboard = Dashboard.objects.create(team=self.team, name="Edit-restricted dashboard", created_by=self.user)
 

ee/api/test/test_event_definition.py

@@ -53,7 +53,7 @@ def setUpTestData(cls):
 
     def test_list_event_definitions(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2500, 1, 19, 3, 14, 7)
         )
 
         response = self.client.get("/api/projects/@current/event_definitions/")
@@ -90,7 +90,7 @@ def test_list_event_definitions(self):
 
     def test_retrieve_existing_event_definition(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EnterpriseEventDefinition.objects.create(team=self.demo_team, name="enterprise event", owner=self.user)
         tag = Tag.objects.create(name="deprecated", team_id=self.demo_team.id)
@@ -112,7 +112,7 @@ def test_retrieve_existing_event_definition(self):
 
     def test_retrieve_create_event_definition(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EventDefinition.objects.create(team=self.demo_team, name="event")
         response = self.client.get(f"/api/projects/@current/event_definitions/{event.id}")
@@ -125,7 +125,7 @@ def test_retrieve_create_event_definition(self):
 
     def test_search_event_definition(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2500, 1, 19, 3, 14, 7)
         )
         enterprise_property = EnterpriseEventDefinition.objects.create(
             team=self.demo_team, name="enterprise event", owner=self.user
@@ -170,7 +170,7 @@ def test_search_event_definition(self):
 
     def test_update_event_definition(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2038, 1, 19, 3, 14, 7)
         )
         event = EnterpriseEventDefinition.objects.create(team=self.demo_team, name="enterprise event", owner=self.user)
         response = self.client.patch(
@@ -226,7 +226,7 @@ def test_update_event_without_license(self):
 
     def test_with_expired_license(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2010, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2010, 1, 19, 3, 14, 7)
         )
         event = EnterpriseEventDefinition.objects.create(team=self.demo_team, name="description test")
         response = self.client.patch(
@@ -241,7 +241,7 @@ def test_with_expired_license(self):
 
     def test_can_get_event_verification_data(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EnterpriseEventDefinition.objects.create(team=self.demo_team, name="enterprise event", owner=self.user)
         response = self.client.get(f"/api/projects/@current/event_definitions/{event.id}")
@@ -258,7 +258,7 @@ def test_can_get_event_verification_data(self):
 
     def test_verify_then_unverify(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EnterpriseEventDefinition.objects.create(team=self.demo_team, name="enterprise event", owner=self.user)
         response = self.client.get(f"/api/projects/@current/event_definitions/{event.id}")
@@ -288,7 +288,7 @@ def test_verify_then_unverify(self):
 
     def test_verify_then_verify_again_no_change(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EnterpriseEventDefinition.objects.create(team=self.demo_team, name="enterprise event", owner=self.user)
         response = self.client.get(f"/api/projects/@current/event_definitions/{event.id}")
@@ -327,7 +327,7 @@ def test_verify_then_verify_again_no_change(self):
 
     def test_cannot_update_verified_meta_properties_directly(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EnterpriseEventDefinition.objects.create(team=self.demo_team, name="enterprise event", owner=self.user)
         response = self.client.get(f"/api/projects/@current/event_definitions/{event.id}")
@@ -358,7 +358,7 @@ def test_event_definition_no_duplicate_tags(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
             key="key_123",
             plan="enterprise",
-            valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7),
+            valid_until=datetime(2038, 1, 19, 3, 14, 7),
         )
         event = EnterpriseEventDefinition.objects.create(team=self.demo_team, name="enterprise event")
         response = self.client.patch(
@@ -370,7 +370,7 @@ def test_event_definition_no_duplicate_tags(self):
 
     def test_event_type_event(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime(2500, 1, 19, 3, 14, 7)
         )
         EnterpriseEventDefinition.objects.create(team=self.demo_team, name="rated_app")
         EnterpriseEventDefinition.objects.create(team=self.demo_team, name="installed_app")

ee/api/test/test_insight.py

@@ -1,8 +1,8 @@
+import datetime
 import json
 from datetime import timedelta
 from typing import cast, Optional
 from django.test import override_settings
-from django.utils import timezone
 from freezegun import freeze_time
 from rest_framework import status
 
@@ -319,7 +319,7 @@ def test_event_definition_no_duplicate_tags(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
             key="key_123",
             plan="enterprise",
-            valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7),
+            valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7),
         )
         dashboard = Dashboard.objects.create(team=self.team, name="Edit-restricted dashboard")
         insight = Insight.objects.create(team=self.team, name="XYZ", created_by=self.user)

ee/api/test/test_license.py

@@ -27,7 +27,7 @@ def test_can_list_and_retrieve_licenses(self):
         self.assertEqual(response_data["results"][0]["key"], "12345::67890")
         self.assertEqual(
             response_data["results"][0]["valid_until"],
-            timezone.datetime(2038, 1, 19, 3, 14, 7, tzinfo=ZoneInfo("UTC")).isoformat().replace("+00:00", "Z"),
+            datetime.datetime(2038, 1, 19, 3, 14, 7, tzinfo=ZoneInfo("UTC")).isoformat().replace("+00:00", "Z"),
         )
 
         retrieve_response = self.client.get(f"/api/license/{response_data['results'][0]['id']}")
@@ -91,13 +91,13 @@ def test_highest_activated_license_is_used_after_upgrade(self):
             License.objects.create(
                 key="old",
                 plan="scale",
-                valid_until=timezone.datetime.now() + timezone.timedelta(days=30),
+                valid_until=datetime.datetime.now() + timezone.timedelta(days=30),
             )
         with freeze_time("2022-06-03T12:00:00.000Z"):
             License.objects.create(
                 key="new",
                 plan="enterprise",
-                valid_until=timezone.datetime.now() + timezone.timedelta(days=30),
+                valid_until=datetime.datetime.now() + timezone.timedelta(days=30),
             )
 
         with freeze_time("2022-06-03T13:00:00.000Z"):
@@ -112,13 +112,13 @@ def test_highest_activated_license_is_used_after_renewal_to_lower(self):
             License.objects.create(
                 key="new",
                 plan="enterprise",
-                valid_until=timezone.datetime.now() + timezone.timedelta(days=30),
+                valid_until=datetime.datetime.now() + timezone.timedelta(days=30),
             )
         with freeze_time("2022-06-27T12:00:00.000Z"):
             License.objects.create(
                 key="old",
                 plan="scale",
-                valid_until=timezone.datetime.now() + timezone.timedelta(days=30),
+                valid_until=datetime.datetime.now() + timezone.timedelta(days=30),
             )
 
         with freeze_time("2022-06-27T13:00:00.000Z"):

ee/api/test/test_property_definition.py

@@ -1,3 +1,4 @@
+import datetime
 from typing import cast, Optional
 from freezegun import freeze_time
 import pytest
@@ -37,7 +38,7 @@ def test_errors_on_invalid_property_type(self):
 
     def test_retrieve_existing_property_definition(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2500, 1, 19, 3, 14, 7)
         )
         property = EnterprisePropertyDefinition.objects.create(team=self.team, name="enterprise property")
         tag = Tag.objects.create(name="deprecated", team_id=self.team.id)
@@ -51,7 +52,7 @@ def test_retrieve_existing_property_definition(self):
 
     def test_retrieve_create_property_definition(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2500, 1, 19, 3, 14, 7)
         )
         property = PropertyDefinition.objects.create(team=self.team, name="property")
         response = self.client.get(f"/api/projects/@current/property_definitions/{property.id}")
@@ -64,7 +65,7 @@ def test_retrieve_create_property_definition(self):
 
     def test_search_property_definition(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2500, 1, 19, 3, 14, 7)
         )
         tag = Tag.objects.create(name="deprecated", team_id=self.team.id)
         EventProperty.objects.create(team=self.team, event="$pageview", property="enterprise property")
@@ -136,7 +137,7 @@ def test_search_property_definition(self):
 
     def test_update_property_definition(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7)
         )
         property = EnterprisePropertyDefinition.objects.create(team=self.team, name="enterprise property")
         response = self.client.patch(
@@ -180,7 +181,7 @@ def test_update_property_definition(self):
 
     def test_update_property_definition_property_type(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7)
         )
 
         property = PropertyDefinition.objects.create(team=self.team, name="property")
@@ -197,7 +198,7 @@ def test_update_property_definition_property_type(self):
 
     def test_update_property_definition_non_numeric(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7)
         )
 
         property = PropertyDefinition.objects.create(
@@ -279,7 +280,7 @@ def test_cannot_update_more_than_property_type_without_license(self):
 
     def test_with_expired_license(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2010, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2010, 1, 19, 3, 14, 7)
         )
         property = EnterprisePropertyDefinition.objects.create(team=self.team, name="description test")
         response = self.client.patch(
@@ -294,7 +295,7 @@ def test_with_expired_license(self):
 
     def test_filter_property_definitions(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2500, 1, 19, 3, 14, 7)
         )
         EnterprisePropertyDefinition.objects.create(team=self.team, name="plan")
         EnterprisePropertyDefinition.objects.create(team=self.team, name="purchase")
@@ -313,7 +314,7 @@ def test_event_property_definition_no_duplicate_tags(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
             key="key_123",
             plan="enterprise",
-            valid_until=timezone.datetime(2038, 1, 19, 3, 14, 7),
+            valid_until=datetime.datetime(2038, 1, 19, 3, 14, 7),
         )
         property = EnterprisePropertyDefinition.objects.create(team=self.team, name="description test")
         response = self.client.patch(
@@ -326,7 +327,7 @@ def test_event_property_definition_no_duplicate_tags(self):
     @freeze_time("2021-08-25T22:09:14.252Z")
     def test_can_get_property_verification_data(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EnterprisePropertyDefinition.objects.create(team=self.team, name="enterprise property")
         response = self.client.get(f"/api/projects/@current/property_definitions/{event.id}")
@@ -344,7 +345,7 @@ def test_can_get_property_verification_data(self):
     @freeze_time("2021-08-25T22:09:14.252Z")
     def test_verify_then_unverify(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EnterprisePropertyDefinition.objects.create(team=self.team, name="enterprise property")
         response = self.client.get(f"/api/projects/@current/property_definitions/{event.id}")
@@ -380,7 +381,7 @@ def test_verify_then_unverify(self):
 
     def test_verify_then_verify_again_no_change(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EnterprisePropertyDefinition.objects.create(team=self.team, name="enterprise property")
         response = self.client.get(f"/api/projects/@current/property_definitions/{event.id}")
@@ -420,7 +421,7 @@ def test_verify_then_verify_again_no_change(self):
     @freeze_time("2021-08-25T22:09:14.252Z")
     def test_cannot_update_verified_meta_properties_directly(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2500, 1, 19, 3, 14, 7)
         )
         event = EnterprisePropertyDefinition.objects.create(team=self.team, name="enterprise property")
         response = self.client.get(f"/api/projects/@current/property_definitions/{event.id}")
@@ -447,7 +448,7 @@ def test_cannot_update_verified_meta_properties_directly(self):
 
     def test_list_property_definitions(self):
         super(LicenseManager, cast(LicenseManager, License.objects)).create(
-            plan="enterprise", valid_until=timezone.datetime(2500, 1, 19, 3, 14, 7)
+            plan="enterprise", valid_until=datetime.datetime(2500, 1, 19, 3, 14, 7)
         )
 
         properties: list[dict] = [