Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Upgrade to Django 5 #23626

Merged
merged 25 commits into from
Aug 29, 2024
Merged

chore(deps): Upgrade to Django 5 #23626

merged 25 commits into from
Aug 29, 2024

Conversation

webjunkie
Copy link
Contributor

@webjunkie webjunkie commented Jul 11, 2024 •
edited
Loading

Problem

Let's see how much trouble it is.

Update: Seems it's not much trouble 🎉

Changes

  • upgrade
  • fix some timezone issue
  • fix some types
  • fix logout - GET is deprecated

Does this work well for both Cloud and self-hosted?

n/a

How did you test this code?

  • relying on all unit and e2e tests here

webjunkie
webjunkie commented Jul 15, 2024
View reviewed changes
posthog/middleware.py Outdated Show resolved Hide resolved
@posthog-bot posthog-bot added stale and removed stale labels Jul 23, 2024
@webjunkie webjunkie removed the stale label Aug 5, 2024
@PostHog PostHog deleted a comment from posthog-bot Aug 5, 2024
@PostHog PostHog deleted a comment from posthog-bot Aug 5, 2024
@webjunkie webjunkie added the waiting Prevents stale-bot from marking the PR as stale. label Aug 8, 2024
@webjunkie
Merge branch 'master' into chore/Django-5
bc5141e 
# Conflicts:
#	ee/billing/billing_manager.py
#	ee/billing/test/test_billing_manager.py
#	mypy-baseline.txt
#	posthog/middleware.py
#	requirements-dev.in
#	requirements-dev.txt
#	requirements.txt
@webjunkie webjunkie self-assigned this Aug 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

Size Change: +44 B (0%)

Total Size: 1.08 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.08 MB +44 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@webjunkie webjunkie marked this pull request as ready for review August 28, 2024 07:16
benjackwhite
benjackwhite approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. The datetime changes are a bit scary as I wonder if there are any other weird places it was missed. We likely will want to do a very robust canary test with this...

cypress/productAnalytics/index.ts Show resolved Hide resolved
posthog/middleware.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-chore/Django-5 August 28, 2024 09:00 Destroyed
@webjunkie
Merge branch 'master' into chore/Django-5
9a87196 
# Conflicts:
#	requirements-dev.txt
#	requirements.in
#	requirements.txt
@webjunkie
Update webdriver manager
6ddc2d8
@github-actions github-actions bot temporarily deployed to pr-chore/Django-5 August 29, 2024 08:50 Destroyed
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@github-actions github-actions bot temporarily deployed to pr-chore/Django-5 August 29, 2024 09:05 Destroyed
@webjunkie webjunkie merged commit 9418235 into master Aug 29, 2024
93 checks passed
@webjunkie webjunkie deleted the chore/Django-5 branch August 29, 2024 09:56
webjunkie added a commit that referenced this pull request Aug 29, 2024
@webjunkie
Revert "chore(deps): Upgrade to Django 5 (#23626)"
cb74df7 
This reverts commit 9418235.
This was referenced Aug 29, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

@pauldambra pauldambra Awaiting requested review from pauldambra

Assignees

@webjunkie webjunkie

Labels
canary deploy waiting Prevents stale-bot from marking the PR as stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webjunkie @posthog-bot @benjackwhite