chore(settings): Clarify persons on events setting #22953
Conversation
|
Size Change: +1.14 kB (+0.11%) Total Size: 1.06 MB
|
📸 UI snapshots have been updated12 snapshot changes in total. 0 added, 12 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
| @@ -62,8 +62,8 @@ export function PersonsOnEvents(): JSX.Element { | |||
|
|
|||
| return ( | |||
| <> | |||
| <p>Choose how to query your event data with person filters.</p> | |||
| <LemonRadio value={poeMode} onChange={setPoeMode} options={poeOptions} /> | |||
| <p>Choose the behavior of person property filters.</p> | |||
There was a problem hiding this comment.
| <p>Choose the behavior of person property filters.</p> | |
| <p>Choose how properties relating to a person change in comparison to the events setting them.</p> |
There was a problem hiding this comment.
I feel like this is a very complex sentence 😅 but it is a complex setting. Actually, I just recalled Tiina made a docs page about this. Added a link to it for those interested in the specifics of "behavior" here:
There was a problem hiding this comment.
I guess my main point here is that this doesn't only affect filters, but everything related to person properties. So maybe just "Choose the behavior of person properties."?
Docs link is great 👍
There was a problem hiding this comment.
Hmm, is there something other than filters affected? (and person IDs for the "fastest" option) So, what I'm thinking is that it's actually a useful distinction to clarify whether this setting is query-time or ingestion-time, and it's the former – so saying it's about the "filters" might be useful in that sense, because it's clear the data stays the same, it's just a different way of querying it
There was a problem hiding this comment.
Hmm, is there something other than filters affected?
Breakdowns, aggregations, etc.
So, what I'm thinking is that it's actually a useful distinction to clarify whether this setting is query-time or ingestion-time,
Yup, super useful! We could also adapt the header to say "Person properties querying" instead of the current "Person properties mode".
so saying it's about the "filters" might be useful in that sense, because it's clear the data stays the same, it's just a different way of querying it
In any case happy for this to go in.
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
* chore(settings): Clarify persons on events setting * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Add docs link * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Say "Recommended" --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Problem
The above setting is only shown in orgs created before June 12th 2024, but that's still a lot of users, and there were a few UX issues:
Changes
This adds
descriptionas aLemonRadioOptionfeature, and makes use of it for increased clarity: