chore(settings): Clarify persons on events setting

frontend/src/lib/lemon-ui/LemonRadio/LemonRadio.stories.tsx

@@ -21,7 +21,7 @@ const meta: Meta<typeof LemonRadio> = {
         options: [
             { value: 'calendar', label: 'Calendar' },
             { value: 'calculator', label: 'Calculator' },
-            { value: 'banana', label: 'Banana' },
+            { value: 'banana', label: 'Banana', disabledReason: 'Bananas are not allowed on pizza' },
             { value: 'settings', label: 'Settings' },
         ] as LemonRadioOption<string>[],
     },
@@ -38,11 +38,17 @@ const Template: StoryFn<typeof LemonRadio> = (props: Omit<LemonRadioProps<any>,
 export const Default: Story = Template.bind({})
 Default.args = {}
 
-export const Disabled: Story = Template.bind({})
-Disabled.args = {
+export const WithDescriptions: Story = Template.bind({})
+WithDescriptions.args = {
     options: [
         { value: 'calendar', label: 'Calendar' },
-        { value: 'calculator', label: 'Calculator' },
-        { value: 'banana', label: 'Banana', disabledReason: 'Bananas are not allowed' },
+        { value: 'calculator', label: 'Calculator', description: '2.1 + 2.01 = 4.109999999999999' },
+        {
+            value: 'banana',
+            label: 'Banana',
+            disabledReason: 'Bananas are not allowed on pizza',
+            description:
+                'Note: The banana addon ships from Costa Rica, which will add 2 working days of a delay to your order.',
+        },
     ],
 }

frontend/src/lib/lemon-ui/LemonRadio/LemonRadio.tsx

@@ -3,6 +3,7 @@ import { Tooltip } from 'lib/lemon-ui/Tooltip'
 
 export interface LemonRadioOption<T extends React.Key> {
     label: string | JSX.Element
+    description?: string | JSX.Element
     value: T
     disabledReason?: string
     'data-attr'?: string
@@ -25,12 +26,12 @@ export function LemonRadio<T extends React.Key>({
 }: LemonRadioProps<T>): JSX.Element {
     return (
         <div className={clsx('flex flex-col gap-2 font-medium', className)}>
-            {options.map(({ value, label, disabledReason, ...optionProps }) => {
+            {options.map(({ value, label, disabledReason, description, ...optionProps }) => {
                 const content = (
                     <label
                         key={value}
                         className={clsx(
-                            'flex items-center space-x-2',
+                            'grid items-center gap-x-2 grid-cols-[min-content_auto] text-sm',
                             disabledReason ? 'text-muted cursor-not-allowed' : 'cursor-pointer'
                         )}
                     >
@@ -48,6 +49,9 @@ export function LemonRadio<T extends React.Key>({
                             {...optionProps}
                         />
                         <span>{label}</span>
+                        {description && (
+                            <div className="text-muted row-start-2 col-start-2 text-pretty">{description}</div>
+                        )}
                     </label>
                 )
 

frontend/src/scenes/settings/project/PersonsOnEvents.tsx

@@ -1,3 +1,4 @@
+import { LemonTag } from '@posthog/lemon-ui'
 import { useActions, useValues } from 'kea'
 import { LemonButton } from 'lib/lemon-ui/LemonButton'
 import { LemonRadio, LemonRadioOption } from 'lib/lemon-ui/LemonRadio'
@@ -9,39 +10,38 @@ import { HogQLQueryModifiers } from '~/queries/schema'
 
 type PoEMode = NonNullable<HogQLQueryModifiers['personsOnEventsMode']>
 
-const poeOptions: LemonRadioOption<PoEMode>[] = [
+const POE_OPTIONS: LemonRadioOption<PoEMode>[] = [
     {
-        value: 'person_id_no_override_properties_on_events',
+        value: 'person_id_override_properties_on_events',
         label: (
+            <span className="inline-flex items-center gap-1.5">
+                Use person properties from the time of the event<LemonTag>DEFAULT</LemonTag>
+            </span>
+        ),
+        description: (
             <>
-                <div>Use person ids and properties from the time of the event.</div>
-                <div className="text-muted">
-                    May show higher unique user counts due to not using latest person ids. You probably want one of the
-                    other options. Fastest queries.
-                </div>
+                Fast queries. If the person property is updated, query results on past data <em>won't</em> change.
             </>
         ),
     },
     {
-        value: 'person_id_override_properties_on_events',
-        label: (
+        value: 'person_id_override_properties_joined',
+        label: 'Use person properties as of running the query',
+        description: (
             <>
-                <div>Use person properties from the time of the event.</div>
-                <div className="text-muted">
-                    Fast queries. If person property is updated, then query results on past data won't change.
-                </div>
+                Slower queries. If the person property is updated, query results on past data <em>will</em> change
+                accordingly.
             </>
         ),
     },
     {
-        value: 'person_id_override_properties_joined',
-        label: (
+        value: 'person_id_no_override_properties_on_events',
+        label: 'Use person IDs and person properties from the time of the event',
+        description: (
             <>
-                <div>Use latest person properties.</div>
-                <div className="text-muted">
-                    Slower queries. If person property is updated, then query results on past data will change to
-                    reflect it.
-                </div>
+                Fastest queries,{' '}
+                <span className="underline">but funnels and unique user counts will be inaccurate</span>. If the person
+                property is updated, query results on past data <em>won't</em> change.
             </>
         ),
     },
@@ -51,7 +51,7 @@ export function PersonsOnEvents(): JSX.Element {
     const { updateCurrentTeam } = useActions(teamLogic)
     const { reportPoEModeUpdated } = useActions(eventUsageLogic)
     const { currentTeam } = useValues(teamLogic)
-    const savedPoEMode =
+    const savedPoEMode: PoEMode =
         currentTeam?.modifiers?.personsOnEventsMode ?? currentTeam?.default_modifiers?.personsOnEventsMode ?? 'disabled'
     const [poeMode, setPoeMode] = useState<PoEMode>(savedPoEMode)
 
@@ -62,8 +62,8 @@ export function PersonsOnEvents(): JSX.Element {
 
     return (
         <>
-            <p>Choose how to query your event data with person filters.</p>
-            <LemonRadio value={poeMode} onChange={setPoeMode} options={poeOptions} />
+            <p>Choose the behavior of person property filters.</p>
+            <LemonRadio value={poeMode} onChange={setPoeMode} options={POE_OPTIONS} />
             <div className="mt-4">
                 <LemonButton
                     type="primary"