fix(hogql): Bring back cohort filter support in actors query #22462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
approved these changes
May 23, 2024
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
|
Backend tests green on bf0108e |
xrdt
pushed a commit
that referenced
this pull request
May 24, 2024
* fix(hogql): Bring back cohort filter support in actors query * Update UI snapshots for `chromium` (1) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
timgl
pushed a commit
that referenced
this pull request
May 24, 2024
* fix(hogql): Bring back cohort filter support in actors query * Update UI snapshots for `chromium` (1) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Made
ActorsQueryschema too strict in #21820, as I missed that cohort filters are supported and commonly used there. This means we currently can't load lists of actors filtered on a specific cohort, like on the cohort page.Changes
Made
AnyPersonScopeFilter, which includes all the supported filter types, including cohorts.