fix(cohorts): fix cohort actors query #22454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
|
Closing in favor of #22462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Persons on the cohorts page are broken see #22450 and e.g. https://us.posthog.com/project/2/cohorts/71789.
Changes
This is because we started disallowing cohort filters (https://github.com/PostHog/posthog/pull/21820/files). This PR simply allows them again.
@Twixes Don't have context on the other PR and stepping through in debugger I can't see why this shouldn't work. Let me know if something should be changed here.
How did you test this code?
Tried locally