Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed feature flag for heatmaps #21886

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

benjackwhite
Copy link
Contributor

Problem

Release time baby!

Changes

  • Removes the flag when we are fully happy.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite requested a review from pauldambra April 26, 2024 09:36
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Size Change: -259 B (0%)

Total Size: 1.04 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.04 MB -259 B (0%)

compressed-size-action

benjackwhite and others added 2 commits April 26, 2024 13:27
# Conflicts:
#	frontend/src/toolbar/stats/HeatmapToolbarMenu.tsx
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

# Conflicts:
#	frontend/src/toolbar/stats/HeatmapToolbarMenu.tsx
@benjackwhite benjackwhite merged commit d77bae8 into master Apr 26, 2024
103 checks passed
@benjackwhite benjackwhite deleted the feat/heatmaps-flag-removal branch April 26, 2024 14:29
fuziontech added a commit that referenced this pull request Apr 26, 2024
* master: (28 commits)
  fix: refactor update animation to do less (#21901)
  fix(plugin-server): add time component to person.force_upgrade (#21899)
  fix(dashboards): Indicate 404/400/500 properly (#21853)
  fix: recording exports (#21900)
  feat: Update SLAs, remove GitHub buttons (#21818)
  chore: Removed feature flag for heatmaps (#21886)
  fix(data-warehouse): Added an error message for empty data source files (#21843)
  feat(surveys): allow to stop surveys once reached enough responses (#21528)
  fix: patch missing pause method in rrweb (#21898)
  fix(hogql): make funnels fast again (#21890)
  fix: Explicitly call out readonly user fields (#21889)
  chore(dev): Allow mypy to run in VS Code extension (#21891)
  feat: Small heatmap UI fixes (#21849)
  feat: Improve Heatmaps UI and notices (#21887)
  fix: Redirection to keep query params (#21881)
  fix: hot path is cooler now (#21888)
  feat(data-warehouse): Moved the table model creation to the data pipeline activity (#21817)
  fix: snapshot response timings (#21885)
  chore(deps): Update posthog-js to 1.130.0 (#21884)
  feat(debug): tabs + better view for non-hogql-query nodes (#21867)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants