chore: Removed feature flag for heatmaps (#21886)

PostHog · Apr 26, 2024 · d77bae8 · d77bae8
1 parent 3ff52df
commit d77bae8
Show file tree

Hide file tree

Showing 10 changed files with 181 additions and 194 deletions.
diff --git a/frontend/__snapshots__/scenes-other-settings--settings-project--dark.png b/frontend/__snapshots__/scenes-other-settings--settings-project--dark.png
diff --git a/frontend/__snapshots__/scenes-other-settings--settings-project--light.png b/frontend/__snapshots__/scenes-other-settings--settings-project--light.png
diff --git a/frontend/__snapshots__/scenes-other-toolbar--heatmap--dark.png b/frontend/__snapshots__/scenes-other-toolbar--heatmap--dark.png
diff --git a/frontend/__snapshots__/scenes-other-toolbar--heatmap--light.png b/frontend/__snapshots__/scenes-other-toolbar--heatmap--light.png
diff --git a/frontend/__snapshots__/scenes-other-toolbar--heatmap-dark--dark.png b/frontend/__snapshots__/scenes-other-toolbar--heatmap-dark--dark.png
diff --git a/frontend/__snapshots__/scenes-other-toolbar--heatmap-dark--light.png b/frontend/__snapshots__/scenes-other-toolbar--heatmap-dark--light.png
diff --git a/frontend/src/lib/constants.tsx b/frontend/src/lib/constants.tsx
@@ -209,7 +209,6 @@ export const FEATURE_FLAGS = {
     SESSION_REPLAY_MOBILE_ONBOARDING: 'session-replay-mobile-onboarding', // owner: #team-replay
     IP_ALLOWLIST_SETTING: 'ip-allowlist-setting', // owner: @benjackwhite
     EMAIL_VERIFICATION_TICKET_SUBMISSION: 'email-verification-ticket-submission', // owner: #team-growth
-    TOOLBAR_HEATMAPS: 'toolbar-heatmaps', // owner: #team-replay
     THEME: 'theme', // owner: @aprilfools
     SESSION_TABLE_PROPERTY_FILTERS: 'session-table-property-filters', // owner: @robbie-c
 } as const

diff --git a/frontend/src/scenes/onboarding/Onboarding.tsx b/frontend/src/scenes/onboarding/Onboarding.tsx
@@ -1,6 +1,5 @@
 import { useActions, useValues } from 'kea'
 import { FEATURE_FLAGS, SESSION_REPLAY_MINIMUM_DURATION_OPTIONS } from 'lib/constants'
-import { useFeatureFlag } from 'lib/hooks/useFeatureFlag'
 import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
 import { useEffect, useState } from 'react'
 import { AndroidInstructions } from 'scenes/onboarding/sdks/session-replay'
@@ -82,8 +81,6 @@ const OnboardingWrapper = ({ children }: { children: React.ReactNode }): JSX.Ele
 const ProductAnalyticsOnboarding = (): JSX.Element => {
     const { currentTeam } = useValues(teamLogic)
 
-    const heatmapsEnabled = useFeatureFlag('TOOLBAR_HEATMAPS')
-
     return (
         <OnboardingWrapper>
             <SDKs
@@ -105,17 +102,15 @@ const ProductAnalyticsOnboarding = (): JSX.Element => {
                         inverseToggle: true,
                     },
 
-                    heatmapsEnabled
-                        ? {
-                              title: 'Enable heatmaps',
-                              description: `If you use our JavaScript libraries, we can capture general clicks, mouse movements,
+                    {
+                        title: 'Enable heatmaps',
+                        description: `If you use our JavaScript libraries, we can capture general clicks, mouse movements,
                                and scrolling to create heatmaps. 
                                No additional events are created, and you can disable this at any time.`,
-                              teamProperty: 'heatmaps_opt_in',
-                              value: currentTeam?.heatmaps_opt_in ?? true,
-                              type: 'toggle',
-                          }
-                        : undefined,
+                        teamProperty: 'heatmaps_opt_in',
+                        value: currentTeam?.heatmaps_opt_in ?? true,
+                        type: 'toggle',
+                    },
                 ]}
             />
         </OnboardingWrapper>

diff --git a/frontend/src/scenes/settings/SettingsMap.tsx b/frontend/src/scenes/settings/SettingsMap.tsx
@@ -89,7 +89,6 @@ export const SettingsMap: SettingSection[] = [
                 id: 'heatmaps',
                 title: 'Heatmaps',
                 component: <HeatmapsSettings />,
-                flag: 'TOOLBAR_HEATMAPS',
             },
             {
                 id: 'exception-autocapture',

diff --git a/frontend/src/toolbar/stats/HeatmapToolbarMenu.tsx b/frontend/src/toolbar/stats/HeatmapToolbarMenu.tsx