Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Support dashboard filters in ActorsQuery #21820

Merged
merged 10 commits into from
May 21, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Apr 24, 2024

Changes

Resolves this Sentry issue.

@Twixes Twixes requested a review from mariusandra April 24, 2024 16:22
@Twixes Twixes marked this pull request as draft April 24, 2024 17:04
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Copy link
Contributor

github-actions bot commented May 9, 2024

Size Change: 0 B

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.05 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot posthog-bot removed the stale label May 21, 2024
@Twixes Twixes marked this pull request as ready for review May 21, 2024 12:30
@Twixes Twixes enabled auto-merge (squash) May 21, 2024 18:50
@Twixes Twixes merged commit 56cf1c6 into master May 21, 2024
83 checks passed
@Twixes Twixes deleted the actors-query-dashboard-filters branch May 21, 2024 19:25
timgl pushed a commit that referenced this pull request May 24, 2024
* fix(insights): Support dashboard filters in ActorsQuery

* Update `test_create_from_template_json_can_provide_query_tile`

* Update insight.py

* Make `ActorsQuery` properties typing tighter

* Update test_insight_model.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants