-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix subscriptions sending twice #21581
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5afacfb
Fix subscriptions sending twice
webjunkie 2c0c251
Adjust calculation, add tests
webjunkie bf1f048
Add another test
webjunkie f164013
Merge branch 'master' into fix/subscriptions-twice
webjunkie c288c0c
Merge branch 'master' into fix/subscriptions-twice
webjunkie 4181cb7
Add buffer as well
webjunkie 39aadc6
Update query snapshots
github-actions[bot] 3dfd3c4
Update query snapshots
github-actions[bot] 03c9a02
Adjust one other test
webjunkie 64f5f98
Merge branch 'master' into fix/subscriptions-twice
webjunkie 7c14e1d
Merge branch 'master' into fix/subscriptions-twice
webjunkie e412b28
Adjust one other test
webjunkie a142098
Merge branch 'master' into fix/subscriptions-twice
webjunkie 8e3ac04
Merge branch 'master' into fix/subscriptions-twice
webjunkie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now recommended to add in Django 4.2, so doing it here while on it.
https://docs.djangoproject.com/en/4.2/releases/4.2/#setting-update-fields-in-model-save-may-now-be-required