feat(hogql): in cohort joins with version as well #21552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2 B (0%) Total Size: 999 kB ℹ️ View Unchanged
|
webjunkie
reviewed
Apr 16, 2024
| @@ -354,6 +357,8 @@ def _add_join_for_cohort( | |||
| if must_add_join: | |||
| if is_static: | |||
| sql = "(SELECT person_id, 1 as matched FROM static_cohort_people WHERE cohort_id = {cohort_id})" | |||
| elif version is not None: | |||
| sql = "(SELECT person_id, 1 as matched FROM raw_cohort_people WHERE cohort_id = {cohort_id} AND version = {version})" | |||
There was a problem hiding this comment.
Where is version value supplied for the placeholder?
There was a problem hiding this comment.
you raise a very good question
webjunkie
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The PR #21543 added an optimization for cohort queries: using a numeric
versiondirectly, instead of grouping by the maximum.Seems like the
joinoption for the "in cohort via" HogQL modifier needed to be modified as well.Changes
Makes the "in cohort via" option "join" also use a faster query.
Does this work well for both Cloud and self-hosted?
Yup
How did you test this code?
This isn't used anywhere, but neither is it tested 🤔