fix(ci): try to ignore temporal #21559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 999 kB ℹ️ View Unchanged
|
|
I'm not sure... wasn't this recently adjusted? #21510 |
|
It was, but this adjusts it further 😅 I'm not sure honestly. I'm just trying not to loose too much time watering CI per day... Happy to do something else 🤔 |
webjunkie
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Do we need Temporal for all tests? This is an annoyingly common sight:
Changes
Doesn't hard fail if temporal can't be started. Surely it's not always needed?
Does this work well for both Cloud and self-hosted?
🤷
How did you test this code?
All tests just passed 🤯
I had a few other PRs where multiple tests kept failing with temporal. Cherry picking this commit made everything just pass.
It doesn't solve all problems, but seems to be a QoL improvement... so... let's merge?