Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error title parsing #21127

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: error title parsing #21127

merged 1 commit into from
Mar 25, 2024

Conversation

pauldambra
Copy link
Member

Problem

Some unexpected input in prod means this page is exploding

Screenshot 2024-03-25 at 11 19 21

  • safely split the error title or return the unmodified item
  • fly-by: since it's a LemonTable now we may as well use built in loading

@pauldambra pauldambra requested a review from a team March 25, 2024 11:20
@sentry-io Sentry.io
Copy link

sentry-io bot commented Mar 25, 2024

Sentry Issue: POSTHOG-RGP

@pauldambra pauldambra enabled auto-merge (squash) March 25, 2024 11:22
@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@pauldambra pauldambra merged commit 61c7794 into master Mar 25, 2024
94 checks passed
@pauldambra pauldambra deleted the fix/error-title-parsing branch March 25, 2024 11:36
@pauldambra pauldambra mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pauldambra