Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helpful JS providing non string types #21130

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

pauldambra
Copy link
Member

follow up to #21127

turns out it wasn't (only) nullish values but rather that when we json parse the error we might not get strings in response

in this case I saw JSON parse returning an error object

so, now we wrap this in a catch, report a title we can't parse, and ensure it's a string before trimming it

@pauldambra pauldambra requested a review from a team March 25, 2024 12:34
@pauldambra pauldambra enabled auto-merge (squash) March 25, 2024 12:41
Copy link
Contributor

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@pauldambra pauldambra merged commit 2389be4 into master Mar 25, 2024
134 of 135 checks passed
@pauldambra pauldambra deleted the fix/helpful-js branch March 25, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants