Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow user to see locally installed apps #20893

Closed
wants to merge 4 commits into from
Closed

fix: allow user to see locally installed apps #20893

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6e83cd
fix: allow user to see locally installed apps
pauldambra Mar 13, 2024
a9d4251
Update UI snapshots for `chromium` (2)
github-actions[bot] Mar 13, 2024
5078836
Merge branch 'master' into fix/view-local-apps
pauldambra Mar 13, 2024
62244cb
Update UI snapshots for `chromium` (2)
github-actions[bot] Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions frontend/src/scenes/plugins/tabs/apps/AppView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@ import { PluginRepositoryEntry, PluginTypeWithConfig } from 'scenes/plugins/type
import { urls } from 'scenes/urls'
import { userLogic } from 'scenes/userLogic'

import { AvailableFeature, PluginType } from '~/types'
import { AvailableFeature, PluginInstallationType, PluginType } from '~/types'

import { PluginTags } from './components'

function isLocalPlugin(plugin: PluginType | PluginRepositoryEntry): boolean {
return 'plugin_type' in plugin && plugin.plugin_type === PluginInstallationType.Local
}

export function AppView({
plugin,
}: {
Expand All @@ -30,7 +34,8 @@ export function AppView({

// If pluginConfig is enabled always show it regardless of the feature availability
// So self-hosted users who were using the plugins in the past can continue to use them
if (!hasAvailableFeature(AvailableFeature.DATA_PIPELINES) && !pluginConfig?.enabled) {
// if plugin is local always show it so developers can test their plugins
if (!hasAvailableFeature(AvailableFeature.DATA_PIPELINES) && !pluginConfig?.enabled && !isLocalPlugin(plugin)) {
// If the app isn't in the allowed apps list don't show it
if (!plugin.url || !PLUGINS_ALLOWED_WITHOUT_DATA_PIPELINES.has(plugin.url)) {
return <></>
Expand Down
Loading