Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow user to see locally installed apps #20893

Closed
wants to merge 4 commits into from

Conversation

pauldambra
Copy link
Member

Was trying to test a plugin locally but the UI hid it from me so I couldn't enable it.

This skips that check for local plugins... I don't know if this is the right fix but at least let me continue for local dev

@pauldambra
Copy link
Member Author

I know there's lots going on with the plugin UI so this might not be the right thing 🤷

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Size Change: 0 B

Total Size: 821 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 821 kB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@benjackwhite benjackwhite removed their request for review March 21, 2024 09:11
@posthog-bot posthog-bot removed the stale label Mar 22, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@tiina303
Copy link
Contributor

tiina303 commented Apr 1, 2024

This is a bit scary as someone could add a local plugin to cloud for testing and we definitely don't want that to be displayed.
The easiest way that already works is make the plugin global. Alternatively we can consider making local dev default show all plugins, would need to think about some gotchas there for self-hosted users.

@pauldambra
Copy link
Member Author

This is a bit scary as someone could add a local plugin to cloud for testing

Cool, I assumed local only ever meant local I guess I was wrong :)

The TL;DR is you can't see plugins to dev them when running locally. I'm happy to close this and leave it at the back of your mind for needing a fix :)

@pauldambra pauldambra closed this Apr 1, 2024
@tiina303
Copy link
Contributor

tiina303 commented Apr 1, 2024

The easiest way that already works is make the plugin global.

Just to confirm - this should solve the problem (if you make the plugin global in the apps management view in pipeline), no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants