-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Experiment with language on billing pages in app #20567
Merged
Merged
Changes from 2 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
f96e4d8
toggle upgrade language depending on flag value
99653cc
forgot some local changes
8f4728c
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
24472cf
update credit card case language
b126319
Update UI snapshots for `chromium` (1)
github-actions[bot] eab15c7
add event to record subscription status
756e0eb
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
060cab2
Update UI snapshots for `chromium` (1)
github-actions[bot] a36121c
Update UI snapshots for `chromium` (2)
github-actions[bot] c598759
add tests
bd3c9d4
remove length check
f156bd1
Update UI snapshots for `chromium` (1)
github-actions[bot] 2020dd7
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
3b6537f
Update UI snapshots for `chromium` (1)
github-actions[bot] bdd10b4
Update UI snapshots for `webkit` (2)
github-actions[bot] 809f967
Update UI snapshots for `chromium` (2)
github-actions[bot] 86ea4b1
Update UI snapshots for `webkit` (2)
github-actions[bot] cae427d
Update UI snapshots for `chromium` (2)
github-actions[bot] e7be167
make common button component
7b398db
some more small changes
f7b0efa
Update UI snapshots for `webkit` (2)
github-actions[bot] 0aa359c
Update UI snapshots for `webkit` (2)
github-actions[bot] f6c6dec
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
eebfea9
remove extraneous files
811bd28
remove optional chaining
3a60b37
Update UI snapshots for `webkit` (2)
github-actions[bot] 37c8aba
Update UI snapshots for `webkit` (2)
github-actions[bot] c1053d7
Update UI snapshots for `webkit` (2)
github-actions[bot] eee2dbf
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
b05947d
remove test...rename event
e5f1928
Merge branch 'master' into by/billing-page-language
xrdt 770e636
Update UI snapshots for `chromium` (1)
github-actions[bot] 6872e41
didn't save before commiting
e750e0c
undo changes to billing cypress test
c94aa31
Update UI snapshots for `chromium` (1)
github-actions[bot] 66db709
Update UI snapshots for `chromium` (2)
github-actions[bot] e3d8e41
finally get cypress to work!
578068f
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
f9de718
small fix to test
e89e47c
Merge remote-tracking branch 'origin' into by/billing-page-language
1bee5a0
Update UI snapshots for `chromium` (2)
github-actions[bot] 15c0b1c
Update UI snapshots for `chromium` (2)
github-actions[bot] 0c06558
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
74a0b70
remove from paygate mini
22fa7de
Update UI snapshots for `chromium` (1)
github-actions[bot] 2859414
Update UI snapshots for `chromium` (2)
github-actions[bot] 195b386
Update UI snapshots for `chromium` (1)
github-actions[bot] 9e3d648
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
3dbfcbc
remove paygate test
4b63d15
Update UI snapshots for `webkit` (2)
github-actions[bot] 8195a88
Update UI snapshots for `chromium` (2)
github-actions[bot] d9075e4
Update UI snapshots for `chromium` (2)
github-actions[bot] 80d1bf7
remove extraneous files
1dd2cfd
remove files!
c78fbf5
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
2f726c2
Update UI snapshots for `webkit` (2)
github-actions[bot] 4f9625d
Update UI snapshots for `chromium` (1)
github-actions[bot] b230f95
Update UI snapshots for `chromium` (2)
github-actions[bot] 96e2d8d
Update UI snapshots for `chromium` (1)
github-actions[bot] 58dff56
Update UI snapshots for `chromium` (1)
github-actions[bot] 4adb470
Merge branch 'master' into by/billing-page-language
raquelmsmith fa83cfc
update tests
e4874b3
Merge remote-tracking branch 'origin/master' into by/billing-page-lan…
e82d259
Update UI snapshots for `webkit` (2)
github-actions[bot] 88e10ac
Update UI snapshots for `chromium` (1)
github-actions[bot] 518f7fd
Update UI snapshots for `chromium` (2)
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this check for whether they have an associated stripe id and therefore have added a credit card before is going to make feature flag analysis complicated. I think we should change this (and all other instances, of course) to say "add credit card" if they don't have a customer_id and "link existing credit card" if they do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think it should be:
Because of the different cohorts here we should make sure we can read results reliably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to say "add paid plan" on the credit card flag w/ subscription condition.