-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Experiment with language on billing pages in app #20567
Conversation
Size Change: +80 B (0%) Total Size: 821 kB ℹ️ View Unchanged
|
Onboarding Billing Step: unsubscribed_plans_onboarding.mp4Billing page and upgrade modal: Screen.Recording.2024-02-26.at.5.16.58.PM.mp4If the user has already added their credit card (i.e. they have a stripe customer id), we will only show 'subscribe' / 'upgrade'. |
frontend/src/scenes/UpgradeModal.tsx
Outdated
<p className="mb-0"> | ||
{featureFlags[FEATURE_FLAGS.BILLING_UPGRADE_LANGUAGE] === 'subscribe' | ||
? 'Subscribe' | ||
: featureFlags[FEATURE_FLAGS.BILLING_UPGRADE_LANGUAGE] === 'credit_card' && !billing?.customer_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this check for whether they have an associated stripe id and therefore have added a credit card before is going to make feature flag analysis complicated. I think we should change this (and all other instances, of course) to say "add credit card" if they don't have a customer_id and "link existing credit card" if they do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think it should be:
- If they do not have active sub:
- "Subscribe" / "Upgrade" / "Add credit card"
- If they do have active sub:
- "Subscribe" / "Upgrade" / "Add (to plan? to my subscription?)"
Because of the different cohorts here we should make sure we can read results reliably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to say "add paid plan" on the credit card flag w/ subscription condition.
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
Going to add some tests to confirm the event capturing but feel free to review @raquelmsmith |
Added test @raquelmsmith |
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that we have the info this already - not as events but as person properties 🙈
See registerInstrumentationProps
in billingLogic
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated13 snapshot changes in total. 0 added, 13 modified, 0 deleted:
Triggered by this commit. |
Problem
Which will perform best in getting people to subscribe:
FF: https://us.posthog.com/project/2/feature_flags/32793
Experiment: https://us.posthog.com/project/2/experiments/18408
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?