Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Experiment with language on billing pages in app #20567

Merged
merged 66 commits into from
Mar 18, 2024

Conversation

xrdt
Copy link
Contributor

@xrdt xrdt commented Feb 27, 2024

Problem

Which will perform best in getting people to subscribe:

  • upgrade
  • subscribe
  • add credit card

FF: https://us.posthog.com/project/2/feature_flags/32793
Experiment: https://us.posthog.com/project/2/experiments/18408

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link
Contributor

github-actions bot commented Feb 27, 2024

Size Change: +80 B (0%)

Total Size: 821 kB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 821 kB +80 B (0%)

compressed-size-action

@xrdt
Copy link
Contributor Author

xrdt commented Feb 27, 2024

Onboarding Billing Step:

unsubscribed_plans_onboarding.mp4

Billing page and upgrade modal:

Screen.Recording.2024-02-26.at.5.16.58.PM.mp4

If the user has already added their credit card (i.e. they have a stripe customer id), we will only show 'subscribe' / 'upgrade'.

@xrdt xrdt requested a review from raquelmsmith February 27, 2024 01:19
<p className="mb-0">
{featureFlags[FEATURE_FLAGS.BILLING_UPGRADE_LANGUAGE] === 'subscribe'
? 'Subscribe'
: featureFlags[FEATURE_FLAGS.BILLING_UPGRADE_LANGUAGE] === 'credit_card' && !billing?.customer_id
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this check for whether they have an associated stripe id and therefore have added a credit card before is going to make feature flag analysis complicated. I think we should change this (and all other instances, of course) to say "add credit card" if they don't have a customer_id and "link existing credit card" if they do.

Copy link
Member

@raquelmsmith raquelmsmith Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think it should be:

  • If they do not have active sub:
    • "Subscribe" / "Upgrade" / "Add credit card"
  • If they do have active sub:
    • "Subscribe" / "Upgrade" / "Add (to plan? to my subscription?)"

Because of the different cohorts here we should make sure we can read results reliably.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to say "add paid plan" on the credit card flag w/ subscription condition.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

7 snapshot changes in total. 0 added, 7 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@xrdt
Copy link
Contributor Author

xrdt commented Mar 1, 2024

Going to add some tests to confirm the event capturing but feel free to review @raquelmsmith

cypress/e2e/billingUpgrade.cy.ts Outdated Show resolved Hide resolved
@xrdt
Copy link
Contributor Author

xrdt commented Mar 1, 2024

Added test @raquelmsmith

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

  • chromium: 0 added, 6 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that we have the info this already - not as events but as person properties 🙈

See registerInstrumentationProps in billingLogic

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

5 snapshot changes in total. 0 added, 5 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

13 snapshot changes in total. 0 added, 13 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@xrdt xrdt merged commit 485fd52 into master Mar 18, 2024
80 checks passed
@xrdt xrdt deleted the by/billing-page-language branch March 18, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants