Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(hogql): replace actors class in funnel tests #20510

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

test(hogql): replace actors class in funnel tests #20510

wants to merge 23 commits into from

Conversation

thmsobrmlr
Copy link
Contributor

Problem

Funnels need to be converted to HogQL (see the funnels section in PostHog/meta#130).

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@thmsobrmlr thmsobrmlr force-pushed the funnel-actor-tests branch 2 times, most recently from a97f797 to c3869b3 Compare February 23, 2024 15:59
Base automatically changed from funnel-strict-actors to master February 26, 2024 09:37
@thmsobrmlr thmsobrmlr removed the stale label Mar 5, 2024
@thmsobrmlr thmsobrmlr mentioned this pull request Mar 8, 2024
Closed
20 tasks
@thmsobrmlr thmsobrmlr removed the stale label Mar 13, 2024
@thmsobrmlr thmsobrmlr removed the stale label Mar 27, 2024
@thmsobrmlr thmsobrmlr removed the stale label Apr 4, 2024
@thmsobrmlr thmsobrmlr removed the stale label Apr 19, 2024
@thmsobrmlr thmsobrmlr reopened this Apr 19, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thmsobrmlr thmsobrmlr removed the stale label May 14, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thmsobrmlr
Merge branch 'master' into funnel-actor-tests
81ec456 
# Conflicts:
#	posthog/hogql_queries/insights/funnels/test/__snapshots__/test_funnel_unordered.ambr
#	posthog/hogql_queries/insights/funnels/test/test_funnel_strict.py
#	posthog/hogql_queries/insights/funnels/test/test_funnel_unordered.py
@posthog-bot posthog-bot removed the stale label May 27, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thmsobrmlr thmsobrmlr removed the stale label Jun 4, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thmsobrmlr thmsobrmlr removed the stale label Jun 12, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thmsobrmlr thmsobrmlr removed the stale label Jun 24, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thmsobrmlr thmsobrmlr removed the stale label Jul 1, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@thmsobrmlr thmsobrmlr removed the stale label Jul 17, 2024
@thmsobrmlr thmsobrmlr reopened this Jul 17, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thmsobrmlr thmsobrmlr added waiting Prevents stale-bot from marking the PR as stale. and removed stale labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting Prevents stale-bot from marking the PR as stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @posthog-bot