-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(hogql): add comparision task for hogql funnels insights #20780
Conversation
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
I guess we moved to a different comparison system and this can be closed? HogQL funnels are live after all. |
Problem
We've converted funnel insights to HogQL and want to make sure we're not introducing regressions.
Changes
This PR contains a Django script for comparing the legacy version of the insight to the HogQL one. It also serves as a checklist for these tests and todo list for things to fix.
python manage.py shell_plus --command compare_hogql_funnel_insights
python manage.py compare_hogql_funnel_insights
Checklist
steps
time_to_convert
trends
ordered
strict
unordered
Todos
SETTINGS
procedural and class based code e.g. to_actors_query takes parameters, but in funnels all subclasses methods access these method, so it can't be passed down
include recordings in trends and stickiness?
How did you test this code?