Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in onboarding flow for Node #20264

Merged
merged 5 commits into from
Feb 14, 2024
Merged

fix: typo in onboarding flow for Node #20264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ae6499
fix typo
Lior539 Feb 12, 2024
8934a84
Update frontend/src/scenes/onboarding/sdks/product-analytics/nodejs.tsx
Lior539 Feb 12, 2024
6eda43c
Merge branch 'master' into fix-onboarding-typo
Lior539 Feb 14, 2024
182d9d1
fix backticks
raquelmsmith Feb 14, 2024
fb29097
Update UI snapshots for `webkit` (2)
github-actions[bot] Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified frontend/__snapshots__/scenes-app-insights--trends-line--light--webkit.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 3 additions & 2 deletions frontend/src/scenes/onboarding/sdks/product-analytics/nodejs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ function NodeCaptureSnippet(): JSX.Element {
})

// Send queued events immediately. Use for example in a serverless environment
// where the program may terminate before everything is sent
client.flush()`}
// where the program may terminate before everything is sent.
// Use \`client.flush()\` instead if you still need to send more events or fetch feature flags.
client.shutdownAsync()`}
</CodeSnippet>
)
}
Expand Down
Loading