Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in onboarding flow for Node #20264

Merged
merged 5 commits into from
Feb 14, 2024
Merged

fix: typo in onboarding flow for Node #20264

merged 5 commits into from
Feb 14, 2024

Conversation

Lior539
Copy link
Contributor

@Lior539 Lior539 commented Feb 12, 2024

Context: https://posthog.slack.com/archives/C01V9AT7DK4/p1707506212271729

You call posthog.shutDownAsync() at the end, but in the project setup you tell us to call client.flush() instead.
posthog is not defined here in this context, and up at the top of the page you import PostHog which in JS would be different things. Leads me to believe this documentation should be updated

@Lior539 Lior539 enabled auto-merge (squash) February 12, 2024 11:08
@raquelmsmith raquelmsmith changed the title Fix typo in onboarding flow for Node fix: typo in onboarding flow for Node Feb 14, 2024
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Size Change: +134 B (0%)

Total Size: 2.22 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 2.22 MB +134 B (0%)

compressed-size-action

@Lior539 Lior539 merged commit 86a3c3b into master Feb 14, 2024
79 checks passed
@Lior539 Lior539 deleted the fix-onboarding-typo branch February 14, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants