Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): remove legacy visual regression tests #19527

Merged
merged 6 commits into from
Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/storybook-chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,6 @@ jobs:
run: |
pnpm test:visual-regression:stories:ci:$VARIANT --browsers ${{ matrix.browser }} --shard ${{ matrix.shard }}/$SHARD_COUNT

- name: Run @playwright/test (legacy, Chromium-only)
if: matrix.browser == 'chromium' && matrix.shard == 1
env:
# Update snapshots for PRs on the main repo, verify on forks, which don't have access to PostHog Bot
VARIANT: ${{ github.event.pull_request.head.repo.full_name == github.repository && 'update' || 'verify' }}
run: |
pnpm test:visual-regression:legacy:ci:$VARIANT

- name: Archive failure screenshots
if: ${{ failure() }}
uses: actions/upload-artifact@v3
Expand Down
6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@
"test": "pnpm test:unit && pnpm test:visual-regression",
"test:unit": "jest --testPathPattern=frontend/",
"jest": "jest",
"test:visual-regression": "docker compose -f docker-compose.playwright.yml run --rm -it --build playwright pnpm test:visual-regression:legacy:docker && pnpm test:visual-regression:stories:docker",
"test:visual-regression:legacy": "docker compose -f docker-compose.playwright.yml run --rm -it --build playwright pnpm test:visual-regression:legacy:docker",
"test:visual-regression:legacy:docker": "STORYBOOK_URL=http://host.docker.internal:6006 playwright test -u",
"test:visual-regression:legacy:ci:update": "playwright test -u",
"test:visual-regression:legacy:ci:verify": "playwright test",
"test:visual-regression": "pnpm test:visual-regression:stories:docker",
"test:visual-regression:stories": "rm -rf frontend/__snapshots__/__failures__/ && docker compose -f docker-compose.playwright.yml run --rm -it --build playwright pnpm test:visual-regression:stories:docker",
"test:visual-regression:stories:docker": "NODE_OPTIONS=--max-old-space-size=6144 test-storybook -u --no-index-json --browsers chromium webkit --url http://host.docker.internal:6006",
"test:visual-regression:stories:local": "NODE_OPTIONS=--max-old-space-size=6144 test-storybook -u --no-index-json --browsers chromium webkit --url http://localhost:6006",
thmsobrmlr marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
66 changes: 0 additions & 66 deletions playwright/e2e-vrt/README.md

This file was deleted.

17 changes: 0 additions & 17 deletions playwright/e2e-vrt/lemon-ui/LemonButton.spec.ts

This file was deleted.

Binary file not shown.
Binary file not shown.
12 changes: 0 additions & 12 deletions playwright/e2e-vrt/scenes-app/PersonsModal.spec.ts

This file was deleted.

Binary file not shown.
Binary file not shown.
33 changes: 0 additions & 33 deletions playwright/e2e-vrt/scenes-app/insights.spec.ts

This file was deleted.

Binary file not shown.
Binary file not shown.
16 changes: 0 additions & 16 deletions playwright/fixtures/storybook.ts

This file was deleted.

12 changes: 0 additions & 12 deletions playwright/helpers/storybook.ts

This file was deleted.

72 changes: 0 additions & 72 deletions playwright/pages/storybook.ts

This file was deleted.

Loading