chore(cleanup): remove legacy visual regression tests #19527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
force-pushed
the
remove-main-app-content
branch
from
4df2973 to
9bf54ca
Compare
thmsobrmlr
force-pushed
the
remove-legacy-vrt
branch
from
c17b574 to
017da76
Compare
thmsobrmlr
force-pushed
the
remove-main-app-content
branch
from
9bf54ca to
254db22
Compare
thmsobrmlr
force-pushed
the
remove-legacy-vrt
branch
from
017da76 to
aaf6e40
Compare
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Twixes
approved these changes
Jan 5, 2024
# Conflicts: # playwright/e2e-vrt/lemon-ui/LemonButton.spec.ts-snapshots/Lemon-Button-displays-disabled-reason-correctly-1-chromium-linux.png
jacobwgillespie
pushed a commit
to jacobwgillespie/posthog
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have two separate ways to run visual regression tests: (a) Page objects that we customize manually (b) Screenshots of storybook while using storybook features to achieve the desired UI state. We've pretty much chosen approach 2 so far an. Let's revisit page objects and Playwright once we look into e2e tests again.
Changes
This PR removes legacy tests, since we are hardly using them any more & this simplifies our setup.
How did you test this code?
CI run