Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(notebooks): remove feature flag #19506

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

thmsobrmlr
Copy link
Contributor

Problem

Notebooks have been rolled out with 3000.

Changes

This PR removes the notebooks flag.

How did you test this code?

👀

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the two parts you missed this looks good and safe enough

Copy link
Contributor

github-actions bot commented Dec 22, 2023

Size Change: -103 B (0%)

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 2 MB -103 B (0%)

compressed-size-action

Base automatically changed from remove-3000-flag to master December 27, 2023 08:52
@thmsobrmlr thmsobrmlr force-pushed the remove-notebooks-flag branch from 3783b68 to 592542b Compare December 27, 2023 11:56
@thmsobrmlr thmsobrmlr mentioned this pull request Dec 27, 2023
28 tasks
@thmsobrmlr thmsobrmlr enabled auto-merge (squash) December 27, 2023 12:05
@thmsobrmlr thmsobrmlr merged commit 8a0d982 into master Dec 27, 2023
78 checks passed
@thmsobrmlr thmsobrmlr deleted the remove-notebooks-flag branch December 27, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants