Skip to content

Commit

Permalink
fix missing occurances
Browse files Browse the repository at this point in the history
  • Loading branch information
thmsobrmlr committed Dec 22, 2023
1 parent 5c813d7 commit 3783b68
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 25 deletions.
26 changes: 12 additions & 14 deletions frontend/src/layout/navigation/SideBar/SideBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -150,20 +150,18 @@ function Pages(): JSX.Element {
},
}}
/>
<FlaggedFeature flag="notebooks">
<PageButton
icon={<IconNotebook />}
identifier={Scene.Notebooks}
to={urls.notebooks()}
sideAction={{
icon: <IconPlus />,
to: urls.notebook('new'),
tooltip: 'New notebook',
identifier: Scene.Notebook,
onClick: hideSideBarMobile,
}}
/>
</FlaggedFeature>
<PageButton
icon={<IconNotebook />}
identifier={Scene.Notebooks}
to={urls.notebooks()}
sideAction={{
icon: <IconPlus />,
to: urls.notebook('new'),
tooltip: 'New notebook',
identifier: Scene.Notebook,
onClick: hideSideBarMobile,
}}
/>
<PageButton
icon={<IconBarChart />}
identifier={Scene.SavedInsights}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/layout/navigation/TopBar/TopBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export function TopBar(): JSX.Element {
url={`${window.location.origin}${window.POSTHOG_APP_CONTEXT.year_in_hog_url}`}
/>
)}
{hasNotebooks && <NotebookButton />}
<NotebookButton />
<NotificationBell />
</>
) : (
Expand Down
17 changes: 7 additions & 10 deletions frontend/src/scenes/dashboard/DashboardHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { router } from 'kea-router'
import { TextCardModal } from 'lib/components/Cards/TextCard/TextCardModal'
import { EditableField } from 'lib/components/EditableField/EditableField'
import { ExportButton, ExportButtonItem } from 'lib/components/ExportButton/ExportButton'
import { FlaggedFeature } from 'lib/components/FlaggedFeature'
import { FullScreen } from 'lib/components/FullScreen'
import { ObjectTags } from 'lib/components/ObjectTags/ObjectTags'
import { PageHeader } from 'lib/components/PageHeader'
Expand Down Expand Up @@ -266,15 +265,13 @@ export function DashboardHeader(): JSX.Element | null {
>
Duplicate dashboard
</LemonButton>
<FlaggedFeature flag={'notebooks'}>
<LemonButton
onClick={() => createNotebookFromDashboard(dashboard)}
status="stealth"
fullWidth
>
Create notebook from dashboard
</LemonButton>
</FlaggedFeature>
<LemonButton
onClick={() => createNotebookFromDashboard(dashboard)}
status="stealth"
fullWidth
>
Create notebook from dashboard
</LemonButton>
{canEditDashboard && (
<LemonButton
onClick={() => {
Expand Down

0 comments on commit 3783b68

Please sign in to comment.