Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hogql): Fix limit and offset required #19492

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Conversation

webjunkie
Copy link
Contributor

@webjunkie webjunkie commented Dec 22, 2023

Problem

Due to caching, some responses don't have limit and offset and this throws errors:
https://posthog.sentry.io/issues/4675259748/

Fixes POSTHOG-MY0

Changes

  • make not required

How did you test this code?

  • just type change
  • tests

@webjunkie webjunkie enabled auto-merge (squash) December 22, 2023 06:49
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@webjunkie webjunkie merged commit 1ba9ba1 into master Dec 22, 2023
78 checks passed
@webjunkie webjunkie deleted the fix/pagination-limit-type branch December 22, 2023 07:34
fuziontech pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants