Skip to content

Commit

Permalink
fix(hogql): Fix limit and offset required (#19492)
Browse files Browse the repository at this point in the history
Fixes POSTHOG-MY0
  • Loading branch information
webjunkie authored and fuziontech committed Jan 4, 2024
1 parent 2b70bfd commit 1b8e0fe
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion frontend/src/queries/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,7 @@
"type": "array"
}
},
"required": ["columns", "types", "results", "hogql", "limit", "offset"],
"required": ["columns", "types", "results", "hogql"],
"type": "object"
},
"FeaturePropertyFilter": {
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/queries/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,9 @@ export interface EventsQueryResponse {
hasMore?: boolean
timings?: QueryTiming[]
/** @asType integer */
limit: number
limit?: number
/** @asType integer */
offset: number
offset?: number
}
export interface EventsQueryPersonColumn {
uuid: string
Expand Down
4 changes: 2 additions & 2 deletions posthog/schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -825,8 +825,8 @@ class EventsQueryResponse(BaseModel):
columns: List
hasMore: Optional[bool] = None
hogql: str
limit: int
offset: int
limit: Optional[int] = None
offset: Optional[int] = None
results: List[List]
timings: Optional[List[QueryTiming]] = None
types: List[str]
Expand Down

0 comments on commit 1b8e0fe

Please sign in to comment.