feat: Discussions panel #19272

benjackwhite · 2023-12-12T11:17:07Z

Problem

Most internally requested feature internally for Notebooks was Comments.

Changes

Adds a new sidepanel called "Discussions" which allows generic commenting and replying on most PostHog pages
Adds a tab with filtering tools for activity, so you can see activity relevant to the dashboard/notebook/insight you are viewing.
Adds a new logic selector like "breadcrumbs" called "activityFilters" for customising the scope of the discussion as well as the Activity panel
Adds a tooltip button when selecting text to comment, which opens the discussion panel with the relevant comments selected.

Follow up work

Display comments in activity (made hard due to the way the thing is designed...)
Only allow commenting on a single line / don't allow broken up marks if possible
Mentions in comments (do we need tiptap for this? 🙈 )
Mentions in notebooks (i.e. - if a new mention is added, eventually add an activity log entry)

How did you test this code?

...

posthog/models/comment.py

# Conflicts: # frontend/__snapshots__/scenes-app-experiments--running-trend-experiment.png # frontend/__snapshots__/scenes-app-insights--trends-area-breakdown--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area-edit--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-multi-edit--webkit.png # frontend/src/layout/navigation-3000/Navigation.scss # latest_migrations.manifest

# Conflicts: # frontend/src/lib/lemon-ui/LemonSelect/LemonSelect.scss

# Conflicts: # frontend/__snapshots__/scenes-app-experiments--running-trend-experiment.png # frontend/src/lib/components/ScrollableShadows/ScrollableShadows.scss

…t/comments-2

github-actions · 2024-01-02T12:08:36Z

Size Change: +5.31 kB (0%)

Total Size: 2 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	2 MB	+5.31 kB (0%)

_{compressed-size-action}

This reverts commit ed8ff15.

github-actions · 2024-01-02T13:03:40Z

Size Change: +5.31 kB (0%)

Total Size: 2 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	2 MB	+5.31 kB (0%)

_{compressed-size-action}

github-actions · 2024-01-02T13:33:29Z

Size Change: +5.26 kB (0%)

Total Size: 2 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	2 MB	+5.26 kB (0%)

_{compressed-size-action}

github-actions · 2024-01-02T14:21:26Z

Size Change: +5.26 kB (0%)

Total Size: 2 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	2 MB	+5.26 kB (0%)

_{compressed-size-action}

github-actions · 2024-01-02T14:37:11Z

Size Change: +5.26 kB (0%)

Total Size: 2 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	2 MB	+5.26 kB (0%)

_{compressed-size-action}

# Conflicts: # frontend/src/lib/components/MemberSelect.tsx

github-actions · 2024-01-02T17:04:19Z

Size Change: +5.31 kB (0%)

Total Size: 2 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	2 MB	+5.31 kB (0%)

_{compressed-size-action}

daibhin · 2024-01-02T18:01:16Z

frontend/src/scenes/persons/personsLogic.tsx

+            (person): ActivityFilters => {
+                return {
+                    scope: ActivityScope.PERSON,
+                    // TODO: Is this correct? It doesn't seem to work...


Just commenting in case you want to come back to this

frontend/src/layout/navigation-3000/sidepanel/panels/activity/activityForSceneLogic.ts

…activityForSceneLogic.ts Co-authored-by: David Newell <[email protected]>

github-actions · 2024-01-02T18:20:54Z

Size Change: +5.31 kB (0%)

Total Size: 2 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	2 MB	+5.31 kB (0%)

_{compressed-size-action}

benjackwhite · 2024-01-04T16:03:17Z

Implements most of #19167

corywatilo and others added 3 commits December 6, 2023 18:08

changed color theme ui (wip)

86b00cf

Update UI snapshots for chromium (1)

fe315a9

Added comments api

2851218

benjackwhite assigned benjackwhite and daibhin Dec 12, 2023

daibhin reviewed Dec 12, 2023

View reviewed changes

posthog/models/comment.py Outdated Show resolved Hide resolved

benjackwhite and others added 3 commits December 12, 2023 14:47

Fixed up tests

4ecb8dc

Update query snapshots

6d8345a

Fixes

6ab8724

daibhin mentioned this pull request Dec 13, 2023

feat: comments frontend #19303

Merged

9 tasks

benjackwhite and others added 6 commits December 15, 2023 14:47

Fixes

a2c391d

Added stories

148b941

Update UI snapshots for chromium (1)

85ad7e4

Update UI snapshots for chromium (2)

a8a7734

Fixes

373c978

feat: comments frontend (#19303)

fd22eab

benjackwhite requested a review from daibhin December 15, 2023 15:10

benjackwhite and others added 13 commits December 15, 2023 16:11

Fix

35f531c

Fixed up button styles

b9d53f3

Fix up

46a1070

Fix

fad3ee8

fix: Change clearable lemonselect to use sideaction

6f50423

Fix

a1ef69b

Merge branch 'master' into fix/select-button-gap

986bd45

# Conflicts: # frontend/src/lib/lemon-ui/LemonSelect/LemonSelect.scss

Update UI snapshots for chromium (2)

c207b66

Merge branch 'feat/scrollable-component' into feat/comments-2

3c6af92

# Conflicts: # frontend/__snapshots__/scenes-app-experiments--running-trend-experiment.png # frontend/src/lib/components/ScrollableShadows/ScrollableShadows.scss

Fix

05d37f0

Fixes

be21dd0

Fixed up lemonbuttonwithsideaction wrapping

53dd609

Merge branch 'feat/comments-2' of github.com:PostHog/posthog into fea…

a2050b8

…t/comments-2

benjackwhite added 6 commits January 2, 2024 13:39

Fix

524c245

Fix

aeaf016

Fixed up a bunch of issues around possible optional detail

ed8ff15

Revert "Fixed up a bunch of issues around possible optional detail"

3e0de81

This reverts commit ed8ff15.

Fix up check

9b7139f

Remove todos

c0a6750

benjackwhite requested a review from pauldambra January 2, 2024 12:57

benjackwhite added 3 commits January 2, 2024 14:18

Fix up

0a9f036

Fix

c7d3138

Fix

af63ae8

benjackwhite added 2 commits January 2, 2024 15:08

Fix test

5e7fae4

Fix up ID changes

b33f167

Fixes

b225efe

benjackwhite added 2 commits January 2, 2024 17:51

Merge branch 'master' into feat/comments-2

0335a92

# Conflicts: # frontend/src/lib/components/MemberSelect.tsx

Fixes

b24c25f

benjackwhite requested a review from daibhin January 2, 2024 17:35

daibhin approved these changes Jan 2, 2024

View reviewed changes

Update frontend/src/layout/navigation-3000/sidepanel/panels/activity/…

380d2f6

…activityForSceneLogic.ts Co-authored-by: David Newell <[email protected]>

benjackwhite merged commit 492e652 into master Jan 4, 2024
79 checks passed

benjackwhite deleted the feat/comments-2 branch January 4, 2024 16:01

jacobwgillespie pushed a commit to jacobwgillespie/posthog that referenced this pull request Jan 12, 2024

feat: Discussions panel (PostHog#19272)

197d28f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Discussions panel #19272

feat: Discussions panel #19272

benjackwhite commented Dec 12, 2023 •

edited

Loading

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

daibhin Jan 2, 2024

github-actions bot commented Jan 2, 2024

benjackwhite commented Jan 4, 2024

feat: Discussions panel #19272

feat: Discussions panel #19272

Conversation

benjackwhite commented Dec 12, 2023 • edited Loading

Problem

Changes

Follow up work

How did you test this code?

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

daibhin Jan 2, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 2, 2024

benjackwhite commented Jan 4, 2024

benjackwhite commented Dec 12, 2023 •

edited

Loading